Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test(fetch): File coverage #1206

Merged
merged 1 commit into from
Feb 6, 2022
Merged

test(fetch): File coverage #1206

merged 1 commit into from
Feb 6, 2022

Conversation

RaisinTen
Copy link
Contributor

This adds coverage for

throw new TypeError('Illegal invocation')
.

Refs: #951
Signed-off-by: Darshan Sen raisinten@gmail.com

@RaisinTen RaisinTen mentioned this pull request Feb 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #1206 (afccb8f) into main (1204ed1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   93.73%   93.78%   +0.04%     
==========================================
  Files          43       43              
  Lines        4023     4021       -2     
==========================================
  Hits         3771     3771              
+ Misses        252      250       -2     
Impacted Files Coverage Δ
lib/client.js 97.91% <100.00%> (-0.01%) ⬇️
lib/fetch/request.js 82.57% <0.00%> (+0.41%) ⬆️
lib/fetch/file.js 67.64% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abf7c45...afccb8f. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a54b8f5 into nodejs:main Feb 6, 2022
@RaisinTen RaisinTen deleted the File-coverage branch February 6, 2022 12:21
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants