Fix settings translations #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Signed-off-by: Adam Treat <treat.adam@gmail.com>
cebtenzzre
requested changes
Jul 18, 2024
There was a problem hiding this comment.
- foundUserDefault is no longer used and can be removed
- userDefaultModelList no longer needs to prepend/append the selected model because the index is set
- I now notice that exportModelList is missing a check for isEmbeddingModel
- With above changes, userDefaultModelList and exportModelList are the same and one can be eliminated - whichever stays should have a comment that it needs to say in sync with m_selectableModels
- The model list is set once on startup and never again - this is a regression, we used to update this automatically
Signed-off-by: Adam Treat <treat.adam@gmail.com>
cebtenzzre
reviewed
Jul 19, 2024
Signed-off-by: Adam Treat <treat.adam@gmail.com>
cebtenzzre
approved these changes
Jul 19, 2024
cebtenzzre
added a commit
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
cebtenzzre
added a commit
that referenced
this pull request
Aug 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.