LocalDocsSettings: fix embedding device selection after #2690 #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
Signed-off-by: Jared Van Bortel <jared@nomic.ai>
manyoso
approved these changes
Aug 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2690 changed
getDevices(), but failed to update the QML for the "Embeddings Device" option on the LocalDocs page to match. Since the PR had absolutely no description, I can't say I was 100% aware of what was being changed or why, so I didn't catch this.This change prevents the "Embeddings Device" selection from showing up as blank if "Auto" was internally selected, either by default or by selecting it in a previous version. It also allows you to select the "Auto" option again after switching to something else.
For consistency with the previous PR, "Auto" is now called "Application default," and the informative description of the "Auto" option has been removed from the UI, including all translations. (I would argue that this cannot possibly be an improvement, but too much time has been spent discussing that already.)