NIP-46: replace npub1...#? notation with bunker://... #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablof7z
approved these changes
Feb 5, 2024
| @@ -17,7 +17,7 @@ The client always starts by generating a random key which is used to communicate | |||
| The remote signer generates a connection token in the form | |||
|
|
|||
| ``` | |||
| <npub1...>#<optional-secret>?relay=wss://...&relay=wss://... | |||
| bunker://<hex-pubkey>?relay=wss://...&relay=wss://...&secret=<optional-secret> | |||
There was a problem hiding this comment.
Is bunker the right name? NIP-46 can be used by all sorts of remote signers, right? not all of them are nsecbunkers.
There was a problem hiding this comment.
It doesn't have to make sense, it's just what people are using. I like it. When I use NIP-46 with nak I like to think it refers to nak bunker.
There was a problem hiding this comment.
cool. definitely not a blocker. 🚢
erskingardner
approved these changes
Feb 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pablof7z
@erskingardner