Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NIP-46: replace npub1...#? notation with bunker://... #1023

Merged
merged 1 commit into from
Feb 6, 2024
Merged

NIP-46: replace npub1...#? notation with bunker://... #1023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions 46.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The client always starts by generating a random key which is used to communicate
The remote signer generates a connection token in the form

```
<npub1...>#<optional-secret>?relay=wss://...&relay=wss://...
bunker://<hex-pubkey>?relay=wss://...&relay=wss://...&secret=<optional-secret>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is bunker the right name? NIP-46 can be used by all sorts of remote signers, right? not all of them are nsecbunkers.

Copy link
Member Author

@fiatjaf fiatjaf Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have to make sense, it's just what people are using. I like it. When I use NIP-46 with nak I like to think it refers to nak bunker.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. definitely not a blocker. 🚢

```

The user copies that token and pastes it in the client UI somehow. Then the client can send events of kind `24133` to the specified relays and wait for responses from the remote signer.
Expand Down Expand Up @@ -96,4 +96,3 @@ The signer key will always be the key of the user who controls the signer device
- **ping**
- params: []
- result: `"pong"`