Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove some unused modules #2355

Closed
wants to merge 1 commit into from
Closed

remove some unused modules #2355

wants to merge 1 commit into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Dec 15, 2020

i couldn't find anything that actually consumed any of these, so let's get rid of them

References

@nlf nlf requested a review from a team as a code owner December 15, 2020 18:39
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 15, 2020
@npm-deploy-user
Copy link

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 41s 40.4s 39.5s 46s🛑 34.5s 33.5s 28.1s 27.8s 33.5s 36.8s✅🐌
repeat install 9.6s 3s 8.6s 3.1s 8.3s 2.5s 7.7s 1.5s 9.1s 2.7s
with warm cache 32.3s 23.3s 33.8s 30.9s 31.3s 18.6s 23.4s 16.8s 29.1s 18.9s
with node_modules 9.2s 5.6s 8.6s 4.4s 9s 3.5s 7.8s 1.9s 9.4s 5.4s
with lockfile 32.6s 28.9s 31s 29.3s 29s 21.7s 21.7s 16.9s 27.4s 24.6s
with warm cache and node_modules 9.3s 3.3s 7.9s 4.1s 8.4s 2.8s 7.6s 2s 9.2s 3s
with warm cache and lockfile 24.7s 10s 26.3s 11.9s 24.3s 8.2s 17.8s 6.3s 21.3s 7.1s
with node_modules and lockfile 10.1s 5s 9.8s 5.1s 8.6s 3.4s 7.8s 1.7s 9.7s 5.3s

@nlf nlf closed this in bd19384 Dec 15, 2020
@imatlopez imatlopez mentioned this pull request Apr 5, 2021
@nlf nlf deleted the nlf/remove-unused-modules branch March 28, 2022 16:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants