Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(audit-level): add info audit level #2923

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 23, 2021

This is a valid level but wasn't configured to be allowed.

Also added this param to the usage output for npm audit

Screen Shot 2021-03-23 at 10 30 35 AM

References

Related to #2715

@wraithgar wraithgar requested a review from a team as a code owner March 23, 2021 17:29
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Mar 23, 2021
@ruyadorno
Copy link
Contributor

ruyadorno commented Mar 23, 2021

I don't think it's related to the changes here but it'd be nice if the helper that generates these options could break/wrap to next line once it hits 80 characters

`npm install` should not be affected by the `auditLevel` config, as the
results of audit do not change its exit status.

PR-URL: #2929
Credit: @wraithgar
Close: #2929
Reviewed-by: @ljharb, @ruyadorno
This is a valid level but wasn't configured to be allowed.

Also added this param to the usage output for `npm audit`

PR-URL: #2923
Credit: @wraithgar
Close: #2923
Reviewed-by: @ruyadorno
@wraithgar wraithgar force-pushed the gar/audit-level-info branch from 6dca5fa to 98efade Compare March 24, 2021 17:27
@wraithgar wraithgar mentioned this pull request Mar 24, 2021
@wraithgar wraithgar closed this in 98efade Mar 24, 2021
@wraithgar wraithgar merged commit 98efade into latest Mar 24, 2021
@wraithgar wraithgar deleted the gar/audit-level-info branch November 2, 2021 20:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants