-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add logs-dir option #4594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found 2 benchmarks with statistically significant performance regressions
timing results
|
lukekarrys
force-pushed
the
lk/redact-log
branch
8 times, most recently
from
March 22, 2022 05:38
bc5d02b
to
4a6a890
Compare
wraithgar
reviewed
Mar 22, 2022
wraithgar
reviewed
Mar 22, 2022
wraithgar
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good cleanup in this feat.
lukekarrys
force-pushed
the
lk/redact-log
branch
2 times, most recently
from
March 23, 2022 00:58
6071834
to
4f98842
Compare
lukekarrys
force-pushed
the
lk/redact-log
branch
from
March 23, 2022 04:26
4f98842
to
c58182d
Compare
wraithgar
approved these changes
Mar 23, 2022
Just a note that this PR should probably be rebased, as I added the deps as separate commits. |
Merged
Closed
This was referenced May 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: npm/npm-registry-fetch#107This also allows logs-max to be set to 0 to disable log file writing.
Closes #4466
Closes #4206