-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
deps: upgrade npm to 8.6.0 #42550
deps: upgrade npm to 8.6.0 #42550
Conversation
Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
This comment was marked as outdated.
This comment was marked as outdated.
If we want the commit queue to be able to land this we'll need to land nodejs/node-core-utils#614 (or something similar) in node-core-utils. |
It'd be great to land this ASAP; node 17 has a very outdated npm rn. |
Commit Queue failed- Loading data for nodejs/node/pull/42550 ✔ Done loading data for nodejs/node/pull/42550 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 8.6.0 (#42550) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-robot:npm-8.6.0 -> nodejs:master Labels npm, fast-track, dont-land-on-v12.x, dont-land-on-v14.x, lts-watch-v16.x Commits 1 - deps: upgrade npm to 8.6.0 Committers 1 - npm team PR-URL: https://github.com/nodejs/node/pull/42550 Fixes: https://github.com/remove Fixes: https://github.com/100% Fixes: https://github.com/make Fixes: https://github.com/move Fixes: https://github.com/really Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/bump Fixes: https://github.com/return Fixes: https://github.com/consolidate Fixes: https://github.com/work Fixes: https://github.com/only Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tierney Cyren Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42550 Fixes: https://github.com/remove Fixes: https://github.com/100% Fixes: https://github.com/make Fixes: https://github.com/move Fixes: https://github.com/really Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/consolidate Fixes: https://github.com/bump Fixes: https://github.com/return Fixes: https://github.com/consolidate Fixes: https://github.com/work Fixes: https://github.com/only Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tierney Cyren Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 31 Mar 2022 22:43:19 GMT ✔ Approvals: 7 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-928307710 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42550#pullrequestreview-928452353 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474922 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/42550#pullrequestreview-928474971 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-928811578 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-929040706 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42550#pullrequestreview-929693993 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-01T08:44:02Z: https://ci.nodejs.org/job/node-test-pull-request/43255/ - Querying data for job/node-test-pull-request/43255/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42550 From https://github.com/nodejs/node * branch refs/pull/42550/merge -> FETCH_HEAD ✔ Fetched commits as be011858446f..6235b690371c -------------------------------------------------------------------------------- [master d81bef3ccd] deps: upgrade npm to 8.6.0 Author: npm team Date: Thu Mar 31 22:43:17 2022 +0000 203 files changed, 4669 insertions(+), 3415 deletions(-) delete mode 100644 deps/npm/lib/utils/deref-command.js delete mode 100644 deps/npm/lib/utils/is-windows-bash.js delete mode 100644 deps/npm/lib/utils/is-windows-shell.js delete mode 100644 deps/npm/lib/utils/path.js rewrite deps/npm/lib/utils/replace-info.js (82%) delete mode 100644 deps/npm/lib/utils/split-package-names.js delete mode 100644 deps/npm/lib/utils/unsupported.js delete mode 100644 deps/npm/lib/utils/usage.js delete mode 100644 deps/npm/lib/utils/with-chown-sync.js create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/common/owner-sync.js create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/with-owner-sync.js create mode 100644 deps/npm/node_modules/@npmcli/fs/lib/with-owner.js delete mode 100644 deps/npm/node_modules/builtins/History.md rewrite deps/npm/node_modules/builtins/Readme.md (87%) delete mode 100644 deps/npm/node_modules/builtins/builtins.json create mode 100644 deps/npm/node_modules/builtins/index.js delete mode 100644 deps/npm/node_modules/builtins/test.js create mode 100644 deps/npm/node_modules/just-diff-apply/index.d.ts create mode 100644 deps/npm/node_modules/just-diff-apply/index.tests.ts create mode 100644 deps/npm/node_modules/make-fetch-happen/lib/dns.js create mode 100644 deps/npm/node_modules/npm-package-arg/README.md create mode 100644 deps/npm/node_modules/npm-registry-fetch/lib/clean-url.js delete mode 100644 deps/npm/node_modules/npm-registry-fetch/lib/silentlog.js rename deps/npm/node_modules/validate-npm-package-name/{ => lib}/index.js (83%) delete mode 100644 deps/npm/node_modules/validate-npm-package-name/test/index.js delete mode 100644 deps/npm/tap-snapshots/test/lib/commands/unpublish.js.test.cjs create mode 100644 deps/npm/tap-snapshots/test/lib/commands/version.js.test.cjs rewrite deps/npm/tap-snapshots/test/lib/utils/log-file.js.test.cjs (82%) rewrite deps/npm/test/coverage-map.js (78%) create mode 100644 deps/npm/test/fixtures/tspawk.js rewrite deps/npm/test/lib/commands/bin.js (93%) rewrite deps/npm/test/lib/commands/edit.js (90%) rewrite deps/npm/test/lib/commands/unpublish.js (73%) delete mode 100644 deps/npm/test/lib/load-all.js delete mode 100644 deps/npm/test/lib/utils/deref-command.js delete mode 100644 deps/npm/test/lib/utils/is-windows-bash.js delete mode 100644 deps/npm/test/lib/utils/is-windows-shell.js rewrite deps/npm/test/lib/utils/is-windows.js (92%) delete mode 100644 deps/npm/test/lib/utils/path.js delete mode 100644 deps/npm/test/lib/utils/split-package-names.js delete mode 100644 deps/npm/test/lib/utils/unsupported.js ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- deps: upgrade npm to 8.6.0https://github.com/nodejs/node/actions/runs/2140194832 |
PR-URL: #42550 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Landed in 2d84620 |
PR-URL: nodejs#42550 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42550 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42550 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
v8.6.0 (2022-03-31)
Features
723a0918a
#4588 feat(version): reify on workspace version change (@ruyadorno)cc6c09431
#4594 feat: add logs-dir config to set custom logging location (@lukekarrys)Bug Fixes
98bfd9a8c
fix: remove always true condition (document server.listen return val #4590) (@XhmikosR)81afa5a88
#4601 fix(unpublish): properly apply publishConfig (@wraithgar)716a07fde
#4607 fix: 100% coverage in tests (@wraithgar)6f9cb490e
#4614 fix(arborist): handle link nodes in old lockfiles correctly (@nlf)18b8b9435
#4617 fix(arborist): make sure resolveParent exists before checking props (@nlf)bd96ae407
#4599 fix(arborist): identify and repair invalid nodes in the virtual tree (@nlf)99d884542
#4599 fix: make sure we loadOverrides on the root node in loadVirtual() (@nlf)45dd8b861
#4609 fix: move shellout logic into commands (@wraithgar)a64acc0bf
#4609 fix: really load all commands in tests, add description to birthday (@wraithgar)d8dcc02cf
#4609 fix: consolidate command alias code (@wraithgar)f76d4f2f6
#4609 fix: consolidate is-windows code (@wraithgar)57d8f75eb
#4609 fix: consolidate node version support logic (@wraithgar)0a957f5e2
#4609 fix: consolidate path delimiter logic (@wraithgar)738a40445
#4609 fix: bump knownBroken to <12.5.0 (@wraithgar)8b65bfd5d
#4629 fix: return otplease fn results (@wraithgar)d8d374d23
#4632 fix: consolidate split-package-names (@wraithgar)cc0a2ec99
#4611 fix: work better with system manpages (docs: Add usage example of readline line-by-line parsing #4610) (@d0sboots)668ec7f33
#4644 fix: only call npmlog progress methods if explicitly requested (@lukekarrys)Documentation
ff1367f01
#4641 docs: recommend prepare over prepublish (@verhovsky)Dependencies
6df061ec2
#4594 deps:npm-registry-fetch@13.1.0
6dd1139c9
#4594 deps:cacache@16.0.3
feb4446d5
#4616 deps:make-fetch-happen@10.1.0
c33b53311
#4613 deps:minipass-fetch@2.1.0
6a4c8ff89
#4606 deps:npm-audit-report@3.0.0
6e0a131d2
#4627 deps:debug@4.3.4
0f1cd60a1
#4627 deps:proc-log@2.0.1
da377eed5
#4627 deps:parse-conflict-json@2.0.2
726a8a07a
#4627 deps:gauge@4.0.4
aac01b89c
#4628 deps:@npmcli/template-oss@3.2.1
52dfaf239
#4630 deps:make-fetch-happen@10.1.1
9778a5387
#4635 deps:init-package-json@3.0.2
86eff5dcc
#4635 deps:npm-package-arg@9.0.2
5b4cbb217
#4635 deps:validate-npm-package-name@4.0.0
a59fd2cb8
#4639 deps:@npmcli/template-oss@3.2.2
679e569d5
#4655 deps:@npmcli/arborist@5.0.4