Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deps: @npmcli/template-oss@3.2.1 #4628

Merged
merged 1 commit into from
Mar 29, 2022
Merged

deps: @npmcli/template-oss@3.2.1 #4628

merged 1 commit into from
Mar 29, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Mar 29, 2022

  • no-shadow was disabled for the cli and arborist due to the amount
    of changes required. These should be fixed later.
  • Manually updated linting in the cli root to match closer to what
    template-oss does
  • Included docs to be managed with template-oss. This required adding
    an empty test for now, with the plan to add real tests later.

@npm-robot
Copy link
Contributor

npm-robot commented Mar 29, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 70.338 ±0.47 39.722 ±0.01 24.568 ±0.55 27.778 ±0.96 3.953 ±0.00 4.140 ±0.04 3.128 ±0.03 16.695 ±0.29 3.214 ±0.03 4.490 ±0.03
#4628 64.321 ±3.58 39.756 ±0.43 25.082 ±0.63 27.823 ±1.19 3.927 ±0.01 4.044 ±0.13 3.146 ±0.07 16.559 ±0.09 3.169 ±0.04 4.699 ±0.07
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 46.676 ±1.37 30.722 ±0.20 18.062 ±0.08 19.238 ±0.27 3.580 ±0.00 3.674 ±0.11 3.382 ±0.14 12.090 ±0.06 3.011 ±0.12 4.021 ±0.00
#4628 47.328 ±1.86 30.491 ±0.03 18.286 ±0.17 19.287 ±0.72 3.652 ±0.05 3.717 ±0.01 3.250 ±0.02 12.272 ±0.33 3.059 ±0.01 4.168 ±0.04

@lukekarrys lukekarrys marked this pull request as ready for review March 29, 2022 17:11
@lukekarrys lukekarrys requested a review from a team as a code owner March 29, 2022 17:11
@lukekarrys lukekarrys force-pushed the lk/template-oss branch 2 times, most recently from 66b10e6 to 34a38ee Compare March 29, 2022 18:07
- `no-shadow` was disabled for the cli and arborist due to the amount
of changes required. These should be fixed later.
- Manually updated linting in the cli root to match closer to what
template-oss does
- Included docs to be managed with template-oss. This required adding
an empty test for now, with the plan to add real tests later.
@lukekarrys lukekarrys changed the title deps: @npmcli/template-oss@3.2.0 deps: @npmcli/template-oss@3.2.1 Mar 29, 2022
@wraithgar wraithgar added the Dependencies Pull requests that update a dependency file label Mar 29, 2022
@lukekarrys lukekarrys merged commit aac01b8 into latest Mar 29, 2022
@lukekarrys lukekarrys deleted the lk/template-oss branch March 29, 2022 21:51
@lukekarrys lukekarrys mentioned this pull request Mar 31, 2022
@lukekarrys lukekarrys mentioned this pull request Apr 1, 2022
@github-actions github-actions bot mentioned this pull request Aug 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants