Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: only call npmlog progress methods if explicitly requested #4644

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

lukekarrys
Copy link
Contributor

Fixes #3314

@lukekarrys lukekarrys requested a review from a team as a code owner March 30, 2022 22:29
@npm-robot
Copy link
Contributor

found 1 benchmarks with statistically significant performance regressions

  • app-large: clean
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 63.823 ±0.88 36.401 ±0.31 22.312 ±0.23 24.979 ±1.05 3.552 ±0.05 3.669 ±0.02 2.909 ±0.02 15.316 ±0.41 2.916 ±0.03 3.984 ±0.02
#4644 74.640 ±1.33 37.189 ±0.38 22.793 ±0.12 25.846 ±0.74 3.746 ±0.02 3.888 ±0.00 3.007 ±0.02 15.565 ±0.22 3.072 ±0.04 4.221 ±0.06
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 51.634 ±9.41 27.390 ±0.10 16.160 ±0.07 17.534 ±0.46 3.360 ±0.05 3.313 ±0.01 2.922 ±0.07 11.221 ±0.24 2.927 ±0.02 3.787 ±0.07
#4644 84.657 ±31.01 42.929 ±20.57 17.128 ±0.06 17.716 ±0.22 3.463 ±0.01 3.382 ±0.01 3.042 ±0.02 11.381 ±0.02 2.841 ±0.07 3.957 ±0.13

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TERM=dumb and --no-progress is ignored
3 participants