Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use ops+robot as git user for all ci #132

Merged
merged 1 commit into from
Apr 15, 2022
Merged

fix: use ops+robot as git user for all ci #132

merged 1 commit into from
Apr 15, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 9, 2022

I'm not sure if we want to do this, or if there was a reason to keep these bot users separate.

This would change the git user of all our CI commits to @npm-robot. This is the user we use to create PRs to nodejs/node (nodejs/node#42550) and add benchmark comments (npm/cli#4716 (comment)).

@lukekarrys lukekarrys requested a review from a team as a code owner April 9, 2022 21:57
@wraithgar
Copy link
Member

I think the intention was to separate the registry team's automated actions from the cli team's. @darcyclarke may have more context there.

@lukekarrys
Copy link
Contributor Author

We also have https://github.com/npm-deploy-user that is used to deploy the statusboard (maybe more?).

The only thing I want from this is for the user that creates commits in the cli to have a GitHub profile like the others. So if we want to keep them separate that can still be accomplished.

@wraithgar
Copy link
Member

Moving it in this direction is probably still the right choice. Separating them out can be a future concern.

@lukekarrys lukekarrys merged commit aeb0162 into main Apr 15, 2022
@lukekarrys lukekarrys deleted the lk/git-user branch April 15, 2022 22:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants