Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Upgrade grpc-gateway and add required protobuf options #204

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

Mierdin
Copy link
Member

@Mierdin Mierdin commented Nov 24, 2020

Closes #192, closes #193

@Mierdin Mierdin force-pushed the fix-deprecation-warnings branch 3 times, most recently from 193bf4d to ac58ebd Compare November 25, 2020 00:20
Signed-off-by: Matt Oswalt <matt@oswalt.dev>
@Mierdin Mierdin force-pushed the fix-deprecation-warnings branch from ac58ebd to 5e55162 Compare November 25, 2020 00:30
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #204 (ff8517d) into master (32f8589) will decrease coverage by 1.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   29.21%   28.07%   -1.15%     
==========================================
  Files          24       24              
  Lines        2413     2237     -176     
==========================================
- Hits          705      628      -77     
+ Misses       1642     1545      -97     
+ Partials       66       64       -2     
Impacted Files Coverage Δ
scheduler/pods.go 46.55% <66.66%> (+0.44%) ⬆️
db/ingestors/lessons.go 55.88% <0.00%> (-3.44%) ⬇️
api/exp/livesessions.go 27.02% <0.00%> (-2.74%) ⬇️
db/ingestors/collections.go 61.90% <0.00%> (-2.54%) ⬇️
db/ingestors/images.go 67.56% <0.00%> (-2.44%) ⬇️
scheduler/namespaces.go 33.92% <0.00%> (-2.08%) ⬇️
services/tracing.go 13.04% <0.00%> (-1.78%) ⬇️
scheduler/secrets.go 54.83% <0.00%> (-1.42%) ⬇️
scheduler/networks.go 34.51% <0.00%> (-1.03%) ⬇️
db/driver_inmem.go 64.12% <0.00%> (-0.88%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc90bc1...5e55162. Read the comment docs.

@Mierdin Mierdin merged commit ffe2a3e into master Nov 25, 2020
@Mierdin Mierdin deleted the fix-deprecation-warnings branch November 25, 2020 00:39
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"option go_package" warning in proto generation protoc-gen-go generator package deprecation notice
1 participant