Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enhance header filtering in getHeadersApplicableToAllResources function to exclude falsy values #588

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Enhance header filtering in getHeadersApplicableToAllResources function to exclude falsy values #588

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b97c2de
Enhance header filtering in getHeadersApplicableToAllResources functi…
ivanvakulov Dec 17, 2024
77b48d3
Update src/utils/headers.ts
ivanvakulov Dec 19, 2024
d0dc70f
Add public assets test suite and configuration for security headers
ivanvakulov Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/utils/headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@
Object.entries(headers)
.filter(([key]) => appliesToAllResources(key as OptionKey))
.map(([key, value]) => ([getNameFromKey(key as OptionKey), headerStringFromObject(key as OptionKey, value)]))
.filter(([_, value]) => Boolean(value))

Check warning on line 180 in src/utils/headers.ts

View workflow job for this annotation

GitHub Actions / ci (ubuntu-latest, 18) 

'_' is defined but never used
ivanvakulov marked this conversation as resolved.
Show resolved Hide resolved
)
return Object.keys(applicableHeaders).length === 0 ? undefined : applicableHeaders
}
Expand Down
Loading