Fix the potential vulnerability of password showcase of external providers #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iders CVE-2024-7259 Issue: Password was visible for external providers after changing input type from password to text in browser developer tools (Inspect tools). Fix: Added the logic for sending the ******* as password text to UI and updating the password only if user makes any change in password. Signed-off-by: Saksham Srivastava <saksham.sa.srivastava@oracle.com>
sandrobonazzola
approved these changes
Oct 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Issue: Password was visible for external providers after changing input type from password to text in browser developer tools (Inspect tools).
Fix: Added the logic for sending the ******* as password text to UI and updating the password only if user makes any change in password.
Fixes CVE-2024-7259
Are you the owner of the code you are sending in, or do you have permission of the owner?
y