Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix the potential vulnerability of password showcase of external providers #969

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix the potential vulnerability of password showcase of external providers #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...web/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/EditProviderModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public EditProviderModel(SearchableListModel sourceListModel, Provider provider)
getUrl().setEntity(provider.getUrl());
getRequiresAuthentication().setEntity(provider.isRequiringAuthentication());
getUsername().setEntity(provider.getUsername());
getPassword().setEntity(provider.getPassword());
getPassword().setEntity("********"); //$NON-NLS-1$
if (provider.isRequiringAuthentication() && provider.getType().isAuthUrlAware()) {
Uri uri = new Uri(provider.getAuthUrl());
if (uri.isValid()) {
Expand Down
2 changes: 2 additions & 0 deletions ...mmonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,9 @@ private void flush() {
provider.setRequiringAuthentication(authenticationRequired);
if (authenticationRequired) {
provider.setUsername(getUsername().getEntity());
if(!getPassword().getEntity().equals("********")) { //$NON-NLS-1$
provider.setPassword(getPassword().getEntity());
}
if (getTenantName().getIsAvailable()) {
OpenStackProviderProperties properties = getOpenStackProviderProperties();
properties.setTenantName(getTenantName().getEntity());
Expand Down