Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[RHELC-244] Verify overriding usupported kernel module inhibition #735

Merged
merged 2 commits into from
Feb 22, 2023
Merged

[RHELC-244] Verify overriding usupported kernel module inhibition #735

merged 2 commits into from
Feb 22, 2023

Conversation

danmyway
Copy link
Member

@danmyway danmyway commented Feb 9, 2023 •
edited by bocekm
Loading

  • add integration test to verify the environment variable introduced overrides the inhibition
  • Introduced in PR#613

Jira Issue: RHELC-244

Checklist

  • PR meets acceptance criteria specified in the Jira issue
  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] is part of the PR title
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending

@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Base: 92.71% // Head: 92.71% // No change to project coverage 👍

Coverage data is based on head (2d47169) compared to base (185cd56).
Patch has no changes to coverable lines.

❗ Current head 2d47169 differs from pull request most recent head 634a5a3. Consider uploading reports for the commit 634a5a3 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files          24       24           
  Lines        3282     3282           
  Branches      576      576           
=======================================
  Hits         3043     3043           
  Misses        172      172           
  Partials       67       67
Flag Coverage Δ
centos-linux-7 87.99% <ø> (ø)
centos-linux-8 89.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
convert2rhel/checks.py 90.99% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

r0x0d
r0x0d reviewed Feb 10, 2023
View reviewed changes
plans/tier1.fmf Outdated Show resolved Hide resolved
r0x0d
r0x0d approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for results

@danmyway
Copy link
Member Author

/packit test

@Venefilyn Venefilyn added the skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. label Feb 13, 2023
@danmyway
Copy link
Member Author

Waiting for results

Results available @r0x0d

r0x0d
r0x0d approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lovely, @danmyway! Thanks for the PR. You can merge it whenever you want.

@r0x0d
Copy link
Member

r0x0d commented Feb 15, 2023

Sadly you have a conflict here, @danmyway :(

@danmyway danmyway force-pushed the test-unsupported-kmod-envar branch 2 times, most recently from 6e31f75 to 22a9b5f Compare February 15, 2023 22:10
@danmyway danmyway requested a review from r0x0d February 16, 2023 23:58
bocekm
bocekm requested changes Feb 17, 2023
View reviewed changes
plans/tier1.fmf Outdated Show resolved Hide resolved
kokesak
kokesak approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@kokesak kokesak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danmyway
Copy link
Member Author

/packit test

1 similar comment
@danmyway
Copy link
Member Author

/packit test

@bocekm
Copy link
Member

bocekm commented Feb 21, 2023

@danmyway, I'm going to create a new PR in a short while, changing the env var a bit. Sorry for such a last minute change. It's because not doing it now would leave us with no chance to change the env var later.

@bocekm bocekm mentioned this pull request Feb 21, 2023
Merged
7 tasks
@danmyway
Copy link
Member Author

@danmyway, I'm going to create a new PR in a short while, changing the env var a bit. Sorry for such a last minute change. It's because not doing it now would leave us with no chance to change the env var later.

Thank you, @bocekm, Should be aligned with the changes now.

@danmyway @bocekm
Verification test for PR#613
3ea2df3 
* add integration test to verify the environment variable introduced
  overrides the inhibition
@danmyway @bocekm
Remove unneccessary comment
634a5a3 
* a comment refering to non-latest Oracle Linux repositories
** since we are not supporting non-latest Oracle Linux conversions, the
comment is not valid anymore

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@bocekm
Copy link
Member

bocekm commented Feb 21, 2023

@danmyway, all test failures are infrastructure-related. Do you want to re-run the failed pipelines?

@danmyway
Copy link
Member Author

@danmyway, all test failures are infrastructure-related. Do you want to re-run the failed pipelines?

All passed @bocekm

@bocekm bocekm merged commit a93b177 into oamg:main Feb 22, 2023
Venefilyn pushed a commit that referenced this pull request Jun 19, 2023
@danmyway @Venefilyn
[RHELC-244] Verify overriding usupported kernel module inhibition (#735)
2af5e0f 
* Verification test for PR#613

* add integration test to verify the environment variable introduced
  overrides the inhibition

Remove unneccessary comment

* a comment refering to non-latest Oracle Linux repositories
** since we are not supporting non-latest Oracle Linux conversions, the
comment is not valid anymore

Signed-off-by: Daniel Diblik <ddiblik@redhat.com>
@danmyway danmyway deleted the test-unsupported-kmod-envar branch September 3, 2024 08:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kokesak kokesak kokesak approved these changes

@bocekm bocekm bocekm approved these changes

@r0x0d r0x0d Awaiting requested review from r0x0d

Assignees
No one assigned
Labels
skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danmyway @r0x0d @bocekm @kokesak @Venefilyn