[RHELC-244] Rename unavailable kmod inhibitor envar #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.71% // Head: 92.71% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 24 24
Lines 3282 3282
Branches 576 576
=======================================
Hits 3043 3043
Misses 172 172
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
7 tasks
bocekm
force-pushed
the
rename-kmod-inhibitor-envvar
branch
from
83e07b4
to
5b45ab1
Compare
bocekm
changed the title
abadger
approved these changes
Feb 21, 2023
Venefilyn
reviewed
Feb 21, 2023
Before we do an upstream release we can still change the CONVERT2RHEL_ALLOW_UNCHECKED_KMODS environment variable used for overriding the check that inhibits the conversion when kernel modules not available in RHEL are loaded. It is not clear what we mean by the word UNCHECKED. The word UNAVAILABLE is more understandable. Also, the use of "first-party" kernel modules is makes it unclear what we mean by that.
bocekm
force-pushed
the
rename-kmod-inhibitor-envvar
branch
from
5b45ab1
to
fd81fe1
Compare
|
@abadger, after talking to @SpyTec I've reworded the message a bit. |
Venefilyn
approved these changes
Feb 21, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we do an upstream release we can still change the CONVERT2RHEL_ALLOW_UNCHECKED_KMODS environment variable used for overriding the check that inhibits the conversion when kernel modules not available in RHEL are loaded. This variable was introduced recently under #613.
It is not clear what we mean by UNCHECKED in the envar. CONVERT2RHEL_ALLOW_UNAVAILABLE_KMODS is more self-explanatory.
Also, this PR rewords the use of "first-party kernel modules" as it's also quite unclear what we mean by that.
The #735 that introduces an integration check for the new environment variable needs to be updated accordingly.
Jira Issue: RHELC-244
Checklist
[RHELC-]is part of the PR titleRelease Pending