Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old approach to the generated static assets module was designed to avoid template haskell. Since that's no longer a requirement, we no longer have to take a promoted-strings approach. This PR replaces the old
static @"some/path"
approach with$(static "some/path)
using TH.The old approach of statically generating a map of all the static assets also meant that any static files added while
ob run
was running wouldn't be usable until theob run
process was terminated and restarted. This PR includes an implementation ofstatic
for theob run
case that allows files to be added and accessed byob run
without restarting (hence the updates to obelisk-command).I have:
develop
branchhlint .
(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)
nix-build release.nix -A build.x86_64-linux --no-out-link
(orx86_64-darwin
on macOS)