Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TH assets #830

Merged
merged 5 commits into from
Dec 19, 2020
Merged

TH assets #830

merged 5 commits into from
Dec 19, 2020

Conversation

ali-abrar
Copy link
Member

@ali-abrar ali-abrar commented Dec 18, 2020

The old approach to the generated static assets module was designed to avoid template haskell. Since that's no longer a requirement, we no longer have to take a promoted-strings approach. This PR replaces the old static @"some/path" approach with $(static "some/path) using TH.

The old approach of statically generating a map of all the static assets also meant that any static files added while ob run was running wouldn't be usable until the ob run process was terminated and restarted. This PR includes an implementation of static for the ob run case that allows files to be added and accessed by ob run without restarting (hence the updates to obelisk-command).

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@ali-abrar ali-abrar force-pushed the aa/th-manifest branch 2 times, most recently from d2b56bd to 2804db0 Compare December 18, 2020 04:01
@ali-abrar ali-abrar changed the title WIP: TH asset manifest TH assets Dec 18, 2020
@ali-abrar ali-abrar merged commit 6573d48 into develop Dec 19, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant