Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Autoreload static asset derivations #831

Merged
merged 8 commits into from
Dec 19, 2020
Merged

Autoreload static asset derivations #831

merged 8 commits into from
Dec 19, 2020

Conversation

ali-abrar
Copy link
Member

@ali-abrar ali-abrar commented Dec 18, 2020

On top of #830

Provides automatic reloading of a staticFiles derivation without restarting ob run.

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@ali-abrar ali-abrar changed the title WIP: Autoreload static asset derivations Autoreload static asset derivations Dec 18, 2020
@ali-abrar ali-abrar merged commit d779d5a into master Dec 19, 2020
madeline-os added a commit that referenced this pull request May 27, 2022
[#831](#831) changed the
way that we generate routes for static assets. The old approach would
place the assets at a path starting with "static". The new approach
added a leading slash, which, when rendered in URLs, would lead to
double slashes at the beginning of routes.

This change brings the new behavior in line with the old behavior.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants