Allow retrieving only warm water profile #74
Conversation
|
The 'Black' code style error in tools.py is unrelated to my PRs, but I nevertheless fixed it in #72. I need to look into how to fix the coverage issue... |
|
The new test was 99% written by GitHub Copilot. But the style seems to fit the other tests and it fixed the coverall issue. However, it could be argued that I put the new test class in the wrong file. At this point I need direction from a reviewer. Once #72 is merged, all checks will pass. |
tests/test_particular_profiles.py
Outdated
| class TestHeatBuilding: | ||
| @classmethod | ||
| def setup_class(cls): |
There was a problem hiding this comment.
Working with a test class does only make sense if there are more than one test functions using that class.
|
If you didn't state the test was AI generated, I'd have guessed it was copied from some StackOverflow that explains test classes. Maybe, just convert it to a plain test function. (Re-factoring everything to use just some test classes will probably be too much for this PR.) |
|
Thanks for accepting the other PR. Now all checks have passed. |
I added a new argument to
HeatBuilding():This causes only the warm water profile to be returned, by setting the sigmoid parameters a, b and c to 0 and only keeping parameter d.
Fixes #73
Fixes #59