Change ballot title to election name #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might need to be refactored later. [GitHub] See #18 for more.
This was a bit of a fun one to solve---redirecting to @ballot then triggers a "You do not have the ability to access this resource." error, which is what sticks. So, users would submit a ballot, immediately be directed to the #show action on that ballot, and then be immediately redirected back to the root url with an error message. (But only if they weren't admin.) [GitHub] This commit resolves #11.
This might not be rendered yet---I'd have to add a print for that.
Now that we have the sanity check to prevent people from opening the form for a nonexistent election, we can make this change.
This will be accessible to everyone, and is more usable anyhow.
This lets not-logged-in people see any notices.
|
I'm gonna set up CI before I merge this one, so I don't have to keep rebuilding this locally. |
Merged
|
Merging. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the ballot title to the election name and also incorporates some sanity checks and flow tweaks.
Closes #11.
Involves #12.Closes #13.