Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PSR-4 Autoloading - Rename file #313

Closed
wants to merge 1 commit into from

Conversation

chrysanthos
Copy link

@chrysanthos chrysanthos commented Mar 14, 2020

I renamed MatrixStatsAggregation.php to MaxAggregation.php to comply with PSR-4 autoloading standard.

The next major version of Composer (v2) will not autoload such files so this has to eventually happen I suppose.

I am not sure if this is a breaking change but I don't see why it would be since the classname and namespace remained as is.

Closes #319

Copy link

@wawan93 wawan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, merge this

@wawan93
Copy link

wawan93 commented Apr 16, 2020

Closes #319

@danineto
Copy link

Hello,

We still have this issue :(

@alexleeelkins
Copy link

please merge this

@mitelg
Copy link

mitelg commented Oct 16, 2020

composer 2 RC2 was just released and according to the developers, it will soon released as stable. so this should really be fixed soon 😊

@84m 84m self-assigned this Oct 24, 2020
@84m 84m closed this Oct 25, 2020
@84m 84m reopened this Oct 25, 2020
@84m
Copy link

84m commented Oct 25, 2020

i just merged this commit in the 7.2 branch with 8c75b81

@84m 84m closed this Oct 25, 2020
@mitelg
Copy link

mitelg commented Oct 26, 2020

would it be possible, to merge this also into the 7.1 branch? we are depending on Symfony 4.4 (LTS) and therefore we cannot use the current 7.2.1 version, where this was fixed

@mitelg
Copy link

mitelg commented Oct 26, 2020

created a PR 😊 #338

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatrixStatsAggregation.php does not comply with psr-4 autoloading standard
6 participants