Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename MatrixStatsAggregation.php to MaxAggregation.php #338

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Rename MatrixStatsAggregation.php to MaxAggregation.php #338

merged 1 commit into from
Oct 26, 2020

Conversation

mitelg
Copy link

@mitelg mitelg commented Oct 26, 2020

cherry pick of this PR #313

we need the fix also for the 7.1.x version, because we are depending on Symfony 4.4 LTS

7.2 uses symfony/serializer ^5.0

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #338 into 7.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                7.1     #338   +/-   ##
=========================================
  Coverage     78.59%   78.59%           
  Complexity      713      713           
=========================================
  Files           123      123           
  Lines          1887     1887           
=========================================
  Hits           1483     1483           
  Misses          404      404           
Impacted Files Coverage Δ Complexity Δ
src/Aggregation/Matrix/MaxAggregation.php 0.00% <ø> (ø) 10.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfcd23...063229c. Read the comment docs.

@84m 84m merged commit 286ad9d into ongr-io:7.1 Oct 26, 2020
@84m
Copy link

84m commented Oct 26, 2020

Thanks for your contribution @mitelg

@mitelg mitelg deleted the rename-class branch October 26, 2020 08:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants