-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Fix] Fix CI bug due to mmcv index #495
Conversation
|
just to check log, seems if -q added, nothing will be printed |
Is this caused by mmdet? The CI was successful before |
@@ -999,5 +1000,5 @@ def train(self, mode=True): | |||
m.eval() | |||
|
|||
|
|||
if 'mmdet' in dir(): | |||
if mmdet_imported: | |||
MMDET_SHARED_HEADS.register_module()(ResNet3dLayer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is too weird. The following is more straight forward.
MMDET_SHARED_HEADS.register_module(ResNet3dLayer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, registry.register_module() return a function,
@MMDET_SHARED_HEADS.register_module()
class ResNet3dLayer():
pass
is equivalent to:
MMDET_SHARED_HEADS.register_module()(ResNet3dLayer)
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
- Coverage 84.71% 84.66% -0.05%
==========================================
Files 120 120
Lines 8407 8414 +7
Branches 1373 1373
==========================================
+ Hits 7122 7124 +2
- Misses 936 942 +6
+ Partials 349 348 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
CI has been fixed in master, so you can remove changes in build.yaml |
Maybe you can still merge my modification. Since there is no built wheel for torch1.5.1 (which means you still can not pass the GPU CI), I modify build.yml to run CI under torch1.5.0 + torchvision 0.6.0. |
Seems although https://download.openmmlab.com/mmcv/dist/cu101/torch1.5.1/index.html is an empty page, you can still install mmcv-full and pass the GPU CI. I'm not sure how does that happen, would you like to share the explanation with me? |
🤷 have no idea. |
@kennymckormick There is no built wheel for torch1.5.1 from a long time ago. We may have a discussion on this issue offline. |
How is it going ? @kennymckormick |
I think OK to merge. |
No description provided.