Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Fix CI bug due to mmcv index #495

Merged
merged 26 commits into from
Jan 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c5f00a8
resolve comments
Oct 16, 2020
05575c1
update changelog
Oct 16, 2020
eb09070
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Oct 19, 2020
81302a4
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Oct 22, 2020
43a649a
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Oct 27, 2020
755809e
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Oct 29, 2020
d478c9d
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 2, 2020
08bbc06
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 7, 2020
ff958e6
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 8, 2020
d0e192d
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 11, 2020
a52c536
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 11, 2020
81a2029
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 16, 2020
e03d2a9
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 17, 2020
2a9b57f
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 27, 2020
28001ff
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Nov 30, 2020
46cc5dd
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Dec 1, 2020
667818a
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Dec 18, 2020
34398a8
Merge branch 'master' of https://github.com/open-mmlab/mmaction2
Dec 18, 2020
8b88f83
remove -q to check
Dec 28, 2020
4181f7c
update checking
Dec 28, 2020
5264a79
Update build.yml
innerlee Dec 29, 2020
49c920a
update CI, GPU use torch 1.5.0
Dec 29, 2020
e6c4e2c
Merge branch 'fixCI' of github.com:kennymckormick/mmaction2 into fixCI
Dec 29, 2020
d326564
Merge branch 'master' into fixCI
kennymckormick Dec 29, 2020
f0b55f8
switch torchvision to 0.6.0
Dec 29, 2020
9f0bf1b
Merge branch 'fixCI' of github.com:kennymckormick/mmaction2 into fixCI
Dec 29, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ jobs:
strategy:
matrix:
python-version: [3.7]
torch: [1.3.0, 1.5.1, 1.6.0, 1.7.0]
torch: [1.3.0, 1.5.0, 1.6.0, 1.7.0]
include:
- torch: 1.3.0
torchvision: 0.4.1
- torch: 1.5.1
torchvision: 0.6.1
- torch: 1.5.0
torchvision: 0.6.0
- torch: 1.6.0
torchvision: 0.7.0
- torch: 1.7.0
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Install MMCV
run: pip install mmcv-full==1.2.2 -f https://download.openmmlab.com/mmcv/dist/cpu/torch${{matrix.torch}}/index.html
- name: Install MMDet
run: pip install -q git+https://github.com/open-mmlab/mmdetection/
run: pip install git+https://github.com/open-mmlab/mmdetection/
- name: Install unittest dependencies
run: pip install -r requirements/tests.txt -r requirements/optional.txt
- name: Build and install
Expand All @@ -80,14 +80,14 @@ jobs:
strategy:
matrix:
python-version: [3.7]
torch: [1.3.0, 1.5.1+cu101, 1.6.0+cu101, 1.7.0+cu101]
torch: [1.3.0, 1.5.0+cu101, 1.6.0+cu101, 1.7.0+cu101]
include:
- torch: 1.3.0
torchvision: 0.4.1
mmcv: "cu101/torch1.3.0"
- torch: 1.5.1+cu101
torchvision: 0.6.1+cu101
mmcv: "cu101/torch1.5.1"
- torch: 1.5.0+cu101
torchvision: 0.6.0+cu101
mmcv: "cu101/torch1.5.0"
- torch: 1.6.0+cu101
torchvision: 0.7.0+cu101
mmcv: "cu101/torch1.6.0"
Expand Down
5 changes: 3 additions & 2 deletions mmaction/core/bbox/assigners/max_iou_assigner_ava.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
import torch

try:
import mmdet # noqa
from mmdet.core.bbox import AssignResult, MaxIoUAssigner
from mmdet.core.bbox.builder import BBOX_ASSIGNERS
mmdet_imported = True
except (ImportError, ModuleNotFoundError):
warnings.warn('Please install mmdet to use AssignResult, MaxIoUAssigner '
'and BBOX_ASSIGNERS')
mmdet_imported = False

if 'mmdet' in dir():
if mmdet_imported:

@BBOX_ASSIGNERS.register_module()
class MaxIoUAssignerAVA(MaxIoUAssigner):
Expand Down
5 changes: 3 additions & 2 deletions mmaction/models/backbones/resnet3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
from ..registry import BACKBONES

try:
import mmdet # noqa
from mmdet.models.builder import SHARED_HEADS as MMDET_SHARED_HEADS
mmdet_imported = True
except (ImportError, ModuleNotFoundError):
warnings.warn('Please install mmdet to use MMDET_SHARED_HEADS')
mmdet_imported = False


class BasicBlock3d(nn.Module):
Expand Down Expand Up @@ -999,5 +1000,5 @@ def train(self, mode=True):
m.eval()


if 'mmdet' in dir():
if mmdet_imported:
MMDET_SHARED_HEADS.register_module()(ResNet3dLayer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is too weird. The following is more straight forward.

MMDET_SHARED_HEADS.register_module(ResNet3dLayer)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, registry.register_module() return a function,

@MMDET_SHARED_HEADS.register_module()
class ResNet3dLayer():
    pass

is equivalent to:

MMDET_SHARED_HEADS.register_module()(ResNet3dLayer)

5 changes: 3 additions & 2 deletions mmaction/models/backbones/resnet3d_slowfast.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@
from .resnet3d import ResNet3d

try:
import mmdet # noqa
from mmdet.models import BACKBONES as MMDET_BACKBONES
mmdet_imported = True
except (ImportError, ModuleNotFoundError):
warnings.warn('Please install mmdet to use MMDET_BACKBONES')
mmdet_imported = False


class ResNet3dPathway(ResNet3d):
Expand Down Expand Up @@ -507,5 +508,5 @@ def forward(self, x):
return out


if 'mmdet' in dir():
if mmdet_imported:
MMDET_BACKBONES.register_module()(ResNet3dSlowFast)
5 changes: 3 additions & 2 deletions mmaction/models/backbones/resnet3d_slowonly.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
from .resnet3d_slowfast import ResNet3dPathway

try:
import mmdet # noqa
from mmdet.models.builder import BACKBONES as MMDET_BACKBONES
mmdet_imported = True
except (ImportError, ModuleNotFoundError):
warnings.warn('Please install mmdet to use MMDET_BACKBONES')
mmdet_imported = False


@BACKBONES.register_module()
Expand Down Expand Up @@ -50,5 +51,5 @@ def __init__(self,
assert not self.lateral


if 'mmdet' in dir():
if mmdet_imported:
MMDET_BACKBONES.register_module()(ResNet3dSlowOnly)
5 changes: 3 additions & 2 deletions mmaction/models/heads/bbox_head.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
from mmaction.core.bbox import bbox_target

try:
import mmdet # noqa
from mmdet.models.builder import HEADS as MMDET_HEADS
mmdet_imported = True
except (ImportError, ModuleNotFoundError):
warnings.warn('Please install mmdet to use MMDET_HEADS')
mmdet_imported = False


class BBoxHeadAVA(nn.Module):
Expand Down Expand Up @@ -217,5 +218,5 @@ def _bbox_crop_undo(bboxes, crop_quadruple):
return bboxes, scores


if 'mmdet' in dir():
if mmdet_imported:
MMDET_HEADS.register_module()(BBoxHeadAVA)
5 changes: 3 additions & 2 deletions mmaction/models/heads/roi_head.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,16 @@
from mmaction.core.bbox import bbox2result

try:
import mmdet # noqa
from mmdet.core.bbox import bbox2roi
from mmdet.models import HEADS as MMDET_HEADS
from mmdet.models.roi_heads import StandardRoIHead
mmdet_imported = True
except (ImportError, ModuleNotFoundError):
warnings.warn('Please install mmdet to use bbox2roi, MMDET_HEADS '
'and StandardRoIHead')
mmdet_imported = False

if 'mmdet' in dir():
if mmdet_imported:

@MMDET_HEADS.register_module()
class AVARoIHead(StandardRoIHead):
Expand Down
5 changes: 3 additions & 2 deletions mmaction/models/roi_extractors/single_straight3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@
warnings.warn('Please install mmcv-full to use RoIAlign and RoIPool')

try:
import mmdet # noqa
from mmdet.models import ROI_EXTRACTORS
mmdet_imported = True
except (ImportError, ModuleNotFoundError):
warnings.warn('Please install mmdet to use ROI_EXTRACTORS')
mmdet_imported = False


class SingleRoIExtractor3D(nn.Module):
Expand Down Expand Up @@ -101,5 +102,5 @@ def forward(self, feat, rois):
return torch.stack(roi_feats, dim=2)


if 'mmdet' in dir():
if mmdet_imported:
ROI_EXTRACTORS.register_module()(SingleRoIExtractor3D)