[Feature] Support FCAF3D on S3DIS dataset in dev-1.x branch
#1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZCMax @JingweiZhang12 Please have a review |
ZCMax
approved these changes
Nov 14, 2022
|
Thanks for your PR, LGTM ~ |
ZCMax
changed the title
dev-1.x branch
| 'seg_valid_class_ids': tuple(range(13)), | ||
| 'seg_all_class_ids': tuple(range(14)) # possibly with 'stair' class | ||
| 'seg_valid_class_ids': (7, 8, 9, 10, 11), | ||
| 'seg_all_class_ids': tuple(range(1, 14)) # possibly with 'stair' class |
There was a problem hiding this comment.
Did you check this modification? If the seg_all_class_ids starts with 0, then the seg_valid_class_ids maybe start with 8? To keep consistency with , maybe 'seg_all_class_ids' : tuple(range(14)). Please check it again.
There was a problem hiding this comment.
I have checked the modification. Both of tuple(range(1, 14)) and tuple(range(14)) seem no effect on the result.
For 'seg_all_class_ids': tuple(range(1, 14)), the seg_label_mapping is array([5, 5, 5, 5, 5, 5, 5, 0, 1, 2, 3, 4, 5, 5]).
For 'seg_all_class_ids': tuple(range(14)), the seg_label_mapping is array([5, 5, 5, 5, 5, 5, 5, 0, 1, 2, 3, 4, 5, 5, 5]).
Both will map the seg class_id start with 0.
There was a problem hiding this comment.
Thanks for your check. Are there any influences between 'seg_valid_class_ids': (7, 8, 9, 10, 11) and 'seg_valid_class_ids': ( 8, 9, 10, 11, 12)
There was a problem hiding this comment.
We should only make sure len(seg_all_class_ids)>=13 and that will not influence other seg_valid_class_ids settings.
JingweiZhang12
approved these changes
Nov 22, 2022
|
@Xiangxu-0103 Please update the README.md and metafile.yml of FCAF3D on the S3DIS dataset. |
ZwwWayne
pushed a commit
to ZwwWayne/mmdetection3d
that referenced
this pull request
Dec 3, 2022
…mlab#1984) * support fcaf3d for s3dis dataset * Update convert_utils.py * Update seg3d_dataset.py * Delete compose.py * fix import error * use `mmengine.Compose` * Update s3dis-3d.py * Update fcaf3d_2xb8_s3dis-3d-5class.py * Update s3dis_dataset.py * update unittest for s3dis * update docs * use `mmcv.Compose` instead of `mmengine.Compose` * update docstring * fix s3dis preprocessing bug * Add typehint * Update config and fix s3dis dataset * update typehit * Update convert_utils.py * Update README and metafile Co-authored-by: Tai-Wang <tab_wang@outlook.com> fix __all__ keyword
ZwwWayne
pushed a commit
to ZwwWayne/mmdetection3d
that referenced
this pull request
Dec 3, 2022
…mlab#1984) * support fcaf3d for s3dis dataset * Update convert_utils.py * Update seg3d_dataset.py * Delete compose.py * fix import error * use `mmengine.Compose` * Update s3dis-3d.py * Update fcaf3d_2xb8_s3dis-3d-5class.py * Update s3dis_dataset.py * update unittest for s3dis * update docs * use `mmcv.Compose` instead of `mmengine.Compose` * update docstring * fix s3dis preprocessing bug * Add typehint * Update config and fix s3dis dataset * update typehit * Update convert_utils.py * Update README and metafile Co-authored-by: Tai-Wang <tab_wang@outlook.com> fix __all__ keyword
ZwwWayne
pushed a commit
that referenced
this pull request
Dec 9, 2022
* add mmengine assertion * add docstring * fix mminstall * fix semantic segmentation configs * fix semantic seg * fix lint * remove unused imports * fix * update pointnet2-s3dis config * update data_list according to scene_idxs * remove useless function * fix bug lack `eval_ann_info` during evaluation * fix bug * update doc * fix lint * fix dataset converter * update mmengine version * delete whitespace * [Fix] fix point cloud loop visualization error (#1914) * fix point cloud loop visualization error * fix browse_dataset * fix browse_dataset * support saving lidar_det Co-authored-by: JingweiZhang12 <zjw18@mails.tsinghua.edu.cn> * [Enhance] Show instance statistics before and after through pipeline (#1863) * add instance statistics before and after through pipeline * add docstring * support showing cat-wise instance statistics * show all statistics of the dataset * small fix * polish code * show table * small fix * rename some varibles * update task name and config for fcos3d++ on nus (#1927) * update docs * update docs * Update det3d_dataset.py * remove unnecessary optional docs * update docs * update docstrings * update docs * fix lint * update docs * [Refactor]: Refactor SASSD (#1901) * refactor sassd * rename some varibles * add ut for sassd * add some comments * add some comments * [Refactor] Use `mmeval.MeanIoU` for `SegMetric` (#1929) * Use mmeval.MeanIoU * fix comments and add self.reset * solve some comments * fix docstring Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> * fix * fix * fix * fix lint * add args and kwargs * [Docs] Add mmyolo link in README (#1935) * [Refactor] Use `mmeval.MeanIoU` for `SegMetric` (#1929) * Use mmeval.MeanIoU * fix comments and add self.reset * add mmyolo Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> * [Fix] fix seg metric issues and circle ci (#1962) * fix circle ci * update * update * [Enhance] Support evaluation for waymo dataset on s3 filesystem when tensorflow>=2.6.0 (#1958) * support tensorflow>2.6.0 * add filter conditions * [Fix]: change --pkl to --pkl-path in the data upgrade scripts (#1965) * [Refactor] update `metainfo` in pkl file and add `categories` into `metainfo` (#1934) * update metainfo in pkl file * update * add version for waymo * update kitti metric * [Refactor] Refactor FCAF3D (#1945) * add fcaf3d config * support inference of fcaf3d on scannet-3d * minor changes * fix config of scannet * align test precision of facaf3d && support training * add ut * fix bugs of dataset conversion and indoor_metric * support fcaf3d on sunrgbd datasets and add rorate_iou_loss ut * small fix * add docstring and typehint * add typehint for SparseTensor * remove pdb * fix fcaf3d ut * [Docs] Update Chinese documentation (#1891) * [Enhance] Add an example of pcd to bin format. (#1973) * [Enhance] Add an example of pcd to bin format. * Fix installation and typo. * [Fix]: fix image conversion of Waymo to avoid information loss (#1979) * add mmeval * [Refactor] rename `CLASSES` and `PALETTE` to `classes` and `palette` in dataset metainfo (#1932) * rame CLASS and PALETTE to class and palette * change mmcv-full to mmcv * fix comments * [CI]: fix CI (#2007) * Update docs && support loading old checkpoints in FCAF3D (#1974) * add loading converted keys and README, metafile * update readme * reorganize readme * add version in FCAF3d detector * fix converter error * [Fix] fix kitti evaluation bugs on test dataset (#2005) * fix kitti test evaluation bugs * update * [Fix] update the key name of modules from mmdet in cfgs (#2011) * [Fix] fix instance statistics when only detecting a single class (#2003) * Update iou_neg_piecewise_sampler.py * fix lint * [Enhance] Remove useless json file converter (#1971) * [Enhance] Refactor the import of `mmdet` (#1947) * fix config * refactor import of `mmdet` * fix lint * fix lint * [Enhance] Speed up evaluation on waymo (#2008) * support fast eval on waymo * support waymo evaluatioin more flexible and faster * support waymo evaluatioin more flexible and faster * renames * add docs * add guides for multi-thread evaluation toolkit * fix docstring * add download link for idx2metainfo * add docstring * set convert_kitti_format=False in Lidar-based methods * fix docs * add docstring * [Features] Support PV_RCNN modules (#1957) * add pvrcnn module code * add voxelsa * fix * fix comments * fix comments * fix comments * add stack sa * fix * fix comments * fix comments * fix * add ut * fix comments * [Fix]Fix a bug in StackQueryAndGroup (#2043) * fix a bug * fix a batch inference bug * fix docs * [Community] Add 'Projects/' folder, and the first example project (#2042) * add project in mmdet3d * fix * fix * [Fix] Fix waymo converter (#2040) * fix waymo converter * [Fix] Update waymo converter and fix lint * Update waymo_converter.py * Update kitti_converter.py * Update update_infos_to_v2.py * revert * fix paths in `update_infos_to_v2` on Windows by using `pathlib` (#2031) * fix paths on Windows by using `pathlib` * refactor Path import * simplify the warning and error when using open3d and MinkowskiEngine (#2027) * [FIX] replace DefaultFormatBundle/3D with Pack(3D)DetInputs (#1987) * replace defaultformatbundle3d with pack3ddetinputs * remove normalize, pad, imagetotensor from configs * rm unused key 'img_norm_cfg' * fix lint errors * fix lint errors * fix lint error * xx * [Docs] Refine the documentation (#1994) * refine doc * refine docs * replace `CLASSES` with `classes` * update doc * Minor fix Co-authored-by: Tai-Wang <tab_wang@outlook.com> * [Fix] Fix some loading bugs and support fov_image_based mode in Waymo dataset. (#1942) * modify sample_id to sample_id and support fov_image_based on waymo dataset * Update waymo_metric.py * Minor fix * Minor fix * Minor fix * Minor fix * Minor fix * Minor fix * Minor fixes * Minor fixes * Remove optional * fix dataset instances converting bugs * Add a blank line to fix the doc compilation format * Fix the bin file name in waymo_fov config * Resolve conflicts * fix ci and other things Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: lianqing11 <lianqing11@foxmail.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> * [Fix] Add num_features in Lyft dataset info file (#1948) Co-authored-by: Tai-Wang <tab_wang@outlook.com> * [Feature] Support FCAF3D on S3DIS dataset in `dev-1.x` branch (#1984) * support fcaf3d for s3dis dataset * Update convert_utils.py * Update seg3d_dataset.py * Delete compose.py * fix import error * use `mmengine.Compose` * Update s3dis-3d.py * Update fcaf3d_2xb8_s3dis-3d-5class.py * Update s3dis_dataset.py * update unittest for s3dis * update docs * use `mmcv.Compose` instead of `mmengine.Compose` * update docstring * fix s3dis preprocessing bug * Add typehint * Update config and fix s3dis dataset * update typehit * Update convert_utils.py * Update README and metafile Co-authored-by: Tai-Wang <tab_wang@outlook.com> * fix pp_waymo * update * resolve Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: JingweiZhang12 <zjw18@mails.tsinghua.edu.cn> Co-authored-by: Qing Lian <lianqing1997@gmail.com> Co-authored-by: Shaun <cq.xiang@foxmail.com> Co-authored-by: Wencheng Wu <41542251+274869388@users.noreply.github.com> Co-authored-by: Erli Ouyang <ouyangerli@gmail.com> Co-authored-by: VVsssssk <88368822+VVsssssk@users.noreply.github.com> Co-authored-by: vavanade <vavanade@users.noreply.github.com> Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: lianqing11 <lianqing11@foxmail.com>
ZwwWayne
pushed a commit
that referenced
this pull request
Dec 9, 2022
…2046) * add mmengine assertion * add docstring * fix mminstall * fix semantic segmentation configs * fix semantic seg * fix lint * remove unused imports * fix * update pointnet2-s3dis config * update data_list according to scene_idxs * remove useless function * fix bug lack `eval_ann_info` during evaluation * fix bug * update doc * fix lint * fix dataset converter * update mmengine version * delete whitespace * [Fix] fix point cloud loop visualization error (#1914) * fix point cloud loop visualization error * fix browse_dataset * fix browse_dataset * support saving lidar_det Co-authored-by: JingweiZhang12 <zjw18@mails.tsinghua.edu.cn> * [Enhance] Show instance statistics before and after through pipeline (#1863) * add instance statistics before and after through pipeline * add docstring * support showing cat-wise instance statistics * show all statistics of the dataset * small fix * polish code * show table * small fix * rename some varibles * update task name and config for fcos3d++ on nus (#1927) * update docs * update docs * Update det3d_dataset.py * remove unnecessary optional docs * update docs * update docstrings * update docs * fix lint * update docs * [Refactor]: Refactor SASSD (#1901) * refactor sassd * rename some varibles * add ut for sassd * add some comments * add some comments * [Refactor] Use `mmeval.MeanIoU` for `SegMetric` (#1929) * Use mmeval.MeanIoU * fix comments and add self.reset * solve some comments * fix docstring Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> * fix * fix * fix * fix lint * add args and kwargs * [Docs] Add mmyolo link in README (#1935) * [Refactor] Use `mmeval.MeanIoU` for `SegMetric` (#1929) * Use mmeval.MeanIoU * fix comments and add self.reset * add mmyolo Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> * [Fix] fix seg metric issues and circle ci (#1962) * fix circle ci * update * update * [Enhance] Support evaluation for waymo dataset on s3 filesystem when tensorflow>=2.6.0 (#1958) * support tensorflow>2.6.0 * add filter conditions * [Fix]: change --pkl to --pkl-path in the data upgrade scripts (#1965) * [Refactor] update `metainfo` in pkl file and add `categories` into `metainfo` (#1934) * update metainfo in pkl file * update * add version for waymo * update kitti metric * [Refactor] Refactor FCAF3D (#1945) * add fcaf3d config * support inference of fcaf3d on scannet-3d * minor changes * fix config of scannet * align test precision of facaf3d && support training * add ut * fix bugs of dataset conversion and indoor_metric * support fcaf3d on sunrgbd datasets and add rorate_iou_loss ut * small fix * add docstring and typehint * add typehint for SparseTensor * remove pdb * fix fcaf3d ut * [Docs] Update Chinese documentation (#1891) * [Enhance] Add an example of pcd to bin format. (#1973) * [Enhance] Add an example of pcd to bin format. * Fix installation and typo. * [Fix]: fix image conversion of Waymo to avoid information loss (#1979) * add mmeval * [Refactor] rename `CLASSES` and `PALETTE` to `classes` and `palette` in dataset metainfo (#1932) * rame CLASS and PALETTE to class and palette * change mmcv-full to mmcv * fix comments * [CI]: fix CI (#2007) * Update docs && support loading old checkpoints in FCAF3D (#1974) * add loading converted keys and README, metafile * update readme * reorganize readme * add version in FCAF3d detector * fix converter error * [Fix] fix kitti evaluation bugs on test dataset (#2005) * fix kitti test evaluation bugs * update * [Fix] update the key name of modules from mmdet in cfgs (#2011) * [Fix] fix instance statistics when only detecting a single class (#2003) * Update iou_neg_piecewise_sampler.py * fix lint * [Enhance] Remove useless json file converter (#1971) * [Enhance] Refactor the import of `mmdet` (#1947) * fix config * refactor import of `mmdet` * fix lint * fix lint * [Enhance] Speed up evaluation on waymo (#2008) * support fast eval on waymo * support waymo evaluatioin more flexible and faster * support waymo evaluatioin more flexible and faster * renames * add docs * add guides for multi-thread evaluation toolkit * fix docstring * add download link for idx2metainfo * add docstring * set convert_kitti_format=False in Lidar-based methods * fix docs * add docstring * [Features] Support PV_RCNN modules (#1957) * add pvrcnn module code * add voxelsa * fix * fix comments * fix comments * fix comments * add stack sa * fix * fix comments * fix comments * fix * add ut * fix comments * fix kitti mono_det bug * [Fix]Fix a bug in StackQueryAndGroup (#2043) * fix a bug * fix a batch inference bug * fix docs * [Community] Add 'Projects/' folder, and the first example project (#2042) * add project in mmdet3d * fix * fix * [Fix] Fix waymo converter (#2040) * fix waymo converter * [Fix] Update waymo converter and fix lint * Update waymo_converter.py * Update kitti_converter.py * Update update_infos_to_v2.py * revert * fix paths in `update_infos_to_v2` on Windows by using `pathlib` (#2031) * fix paths on Windows by using `pathlib` * refactor Path import * simplify the warning and error when using open3d and MinkowskiEngine (#2027) * [FIX] replace DefaultFormatBundle/3D with Pack(3D)DetInputs (#1987) * replace defaultformatbundle3d with pack3ddetinputs * remove normalize, pad, imagetotensor from configs * rm unused key 'img_norm_cfg' * fix lint errors * fix lint errors * fix lint error * xx * [Docs] Refine the documentation (#1994) * refine doc * refine docs * replace `CLASSES` with `classes` * update doc * Minor fix Co-authored-by: Tai-Wang <tab_wang@outlook.com> * Update converter * [Fix] Fix some loading bugs and support fov_image_based mode in Waymo dataset. (#1942) * modify sample_id to sample_id and support fov_image_based on waymo dataset * Update waymo_metric.py * Minor fix * Minor fix * Minor fix * Minor fix * Minor fix * Minor fix * Minor fixes * Minor fixes * Remove optional * fix dataset instances converting bugs * Add a blank line to fix the doc compilation format * Fix the bin file name in waymo_fov config * Resolve conflicts * fix ci and other things Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: lianqing11 <lianqing11@foxmail.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> * [Fix] Add num_features in Lyft dataset info file (#1948) Co-authored-by: Tai-Wang <tab_wang@outlook.com> * [Feature] Support FCAF3D on S3DIS dataset in `dev-1.x` branch (#1984) * support fcaf3d for s3dis dataset * Update convert_utils.py * Update seg3d_dataset.py * Delete compose.py * fix import error * use `mmengine.Compose` * Update s3dis-3d.py * Update fcaf3d_2xb8_s3dis-3d-5class.py * Update s3dis_dataset.py * update unittest for s3dis * update docs * use `mmcv.Compose` instead of `mmengine.Compose` * update docstring * fix s3dis preprocessing bug * Add typehint * Update config and fix s3dis dataset * update typehit * Update convert_utils.py * Update README and metafile Co-authored-by: Tai-Wang <tab_wang@outlook.com> * Update kitti_dataset.py * replace `List` wiith `Tuple` format to represent `origin` * Update convert_utils.py * add comments * update * resolve Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: JingweiZhang12 <zjw18@mails.tsinghua.edu.cn> Co-authored-by: Qing Lian <lianqing1997@gmail.com> Co-authored-by: Shaun <cq.xiang@foxmail.com> Co-authored-by: Wencheng Wu <41542251+274869388@users.noreply.github.com> Co-authored-by: Erli Ouyang <ouyangerli@gmail.com> Co-authored-by: VVsssssk <88368822+VVsssssk@users.noreply.github.com> Co-authored-by: vavanade <vavanade@users.noreply.github.com> Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: lianqing11 <lianqing11@foxmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support FCAF3D on S3DIS Dataset
I have benchmarked the performance.
Where the values in brackets are provided by the original paper.