-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Feature] Add inferencer for LiDAR-based detection #2208
[Feature] Add inferencer for LiDAR-based detection #2208
Conversation
The UT and inference with an example input are OK.
|
@gaotongxiao, please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issues overall are similar to #2190. You can revise your code according to the comments in that PR.
Codecov ReportBase: 46.12% // Head: 46.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2208 +/- ##
===========================================
+ Coverage 46.12% 46.37% +0.24%
===========================================
Files 258 259 +1
Lines 21285 21390 +105
Branches 3365 3379 +14
===========================================
+ Hits 9818 9919 +101
Misses 10827 10827
- Partials 640 644 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Inherit from the BaseInferencer in MMEngine
Modification
Compare with the MonoDet3D inferencer PR, there are some modifications:
_inputs_to_list
to BaseDet3DInferencer.INFERENCERS
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist