Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Add inferencer for LiDAR-based detection #2208

Merged
merged 12 commits into from
Jan 31, 2023

Conversation

JingweiZhang12
Copy link
Contributor

@JingweiZhang12 JingweiZhang12 commented Jan 9, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Inherit from the BaseInferencer in MMEngine

Modification

Compare with the MonoDet3D inferencer PR, there are some modifications:

  1. Move _inputs_to_list to BaseDet3DInferencer.
  2. inputs type here: dict[list] > list[dict]
  3. unify some naming formats.
  4. Add registry INFERENCERS

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JingweiZhang12
Copy link
Contributor Author

JingweiZhang12 commented Jan 9, 2023

The UT and inference with an example input are OK.
TODO:

  • docstrings need to be polished.
  • LidarDet3DInferencer will inherit from BaseDet3DInferencer in the PR [Feature] add mono3d inferencer #2190 and remove some duplicated function. This modification will be done when PR2190 is merged.

@JingweiZhang12
Copy link
Contributor Author

@gaotongxiao, please review this PR.

Copy link

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issues overall are similar to #2190. You can revise your code according to the comments in that PR.

mmdet3d/apis/inferencer/lidar_det3d_inferencer.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 46.12% // Head: 46.37% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (516e538) compared to base (278df1e).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2208      +/-   ##
===========================================
+ Coverage    46.12%   46.37%   +0.24%     
===========================================
  Files          258      259       +1     
  Lines        21285    21390     +105     
  Branches      3365     3379      +14     
===========================================
+ Hits          9818     9919     +101     
  Misses       10827    10827              
- Partials       640      644       +4     
Flag Coverage Δ
unittests 46.37% <60.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/transforms/loading.py 47.33% <41.66%> (-0.22%) ⬇️
mmdet3d/apis/inferencers/lidar_det3d_inferencer.py 57.57% <57.57%> (ø)
mmdet3d/apis/inferencers/base_det3d_inferencer.py 86.31% <73.33%> (-1.19%) ⬇️
mmdet3d/apis/__init__.py 100.00% <100.00%> (ø)
mmdet3d/apis/inferencers/__init__.py 100.00% <100.00%> (ø)
mmdet3d/apis/inferencers/mono_det3d_inferencer.py 89.83% <100.00%> (+4.98%) ⬆️
mmdet3d/registry.py 100.00% <100.00%> (ø)
mmdet3d/datasets/transforms/transforms_3d.py 33.33% <0.00%> (+0.11%) ⬆️
mmdet3d/structures/det3d_data_sample.py 98.41% <0.00%> (+0.16%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12 JingweiZhang12 requested review from ZCMax and removed request for ZCMax January 31, 2023 07:52
@ZwwWayne ZwwWayne merged commit f06ce29 into open-mmlab:dev-1.x Jan 31, 2023
@JingweiZhang12 JingweiZhang12 deleted the inferencer_lidar branch March 18, 2023 13:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants