Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Create SemanticKITTI pkl #2253

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

xizaoqu
Copy link
Contributor

@xizaoqu xizaoqu commented Feb 3, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Create SemanticKITTI pkl

Modification

Add SemanticKITTI pkl creation in create_data.py

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@xizaoqu xizaoqu closed this Feb 3, 2023
@xizaoqu xizaoqu reopened this Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 46.39% // Head: 47.09% // Increases project coverage by +0.69% 🎉

Coverage data is based on head (093309c) compared to base (6810244).
Patch coverage: 86.92% of modified lines in pull request are covered.

❗ Current head 093309c differs from pull request most recent head 4e96de8. Consider uploading reports for the commit 4e96de8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2253      +/-   ##
===========================================
+ Coverage    46.39%   47.09%   +0.69%     
===========================================
  Files          259      261       +2     
  Lines        21401    21679     +278     
  Branches      3379     3425      +46     
===========================================
+ Hits          9930    10210     +280     
+ Misses       10827    10816      -11     
- Partials       644      653       +9     
Flag Coverage Δ
unittests 47.09% <86.92%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
mmdet3d/models/dense_heads/fcaf3d_head.py 16.23% <ø> (ø)
mmdet3d/testing/data_utils.py 70.83% <ø> (ø)
mmdet3d/datasets/transforms/loading.py 48.13% <59.37%> (+0.79%) ⬆️
mmdet3d/visualization/local_visualizer.py 34.01% <63.15%> (-0.25%) ⬇️
mmdet3d/models/backbones/mink_resnet.py 25.00% <70.00%> (+2.19%) ⬆️
mmdet3d/models/segmentors/encoder_decoder.py 17.20% <72.72%> (ø)
mmdet3d/models/segmentors/base.py 57.69% <75.00%> (+5.06%) ⬆️
mmdet3d/visualization/vis_utils.py 40.47% <75.00%> (+1.19%) ⬆️
mmdet3d/evaluation/metrics/panoptic_seg_metric.py 90.00% <90.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit 77e0c65 into open-mmlab:dev-1.x Feb 20, 2023
xizaoqu added a commit to xizaoqu/mmdetection3d that referenced this pull request Mar 15, 2023
* creat semantickitti

* update

* update

* update
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants