Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add DTLS 1.3 support #586

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Add DTLS 1.3 support #586

merged 10 commits into from
Dec 13, 2024

Conversation

baentsch
Copy link
Member

As per openssl/openssl#13900 (comment), this PR adds version-conditional (also testing) support for DTLS1.3. This has been manually successfully tested against openssl feature/dtls-1.3 branch. CI will automatically run DTLS test cases as and when DTLS1.3 lands for good in OpenSSL.

Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
Signed-off-by: Michael Baentsch <57787676+baentsch@users.noreply.github.com>
@baentsch baentsch requested a review from a team December 10, 2024 13:42
Copy link

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baentsch baentsch added this to the 0.8.0 milestone Dec 12, 2024
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, LGTM.

@baentsch baentsch merged commit f7228d2 into main Dec 13, 2024
56 checks passed
@baentsch baentsch deleted the dtls-1.3 branch December 13, 2024 08:18
@baentsch
Copy link
Member Author

@praveksharma fyi, this was the last PR blocking the 0.8.0 release that you volunteered doing. Please note that #545 has not been resolved so a manual test is still needed: Please let me know if you'll do it or whether I should do that. A failure impacts OpenSSL CI if/when the release gets integrated there.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants