Terminate execution for criu that does not meet version requirements #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, could you have a test case? |
kolyshkin
reviewed
Oct 9, 2024
libcontainer/criu_linux.go
Outdated
| @@ -186,7 +186,7 @@ func criuNsToKey(t configs.NamespaceType) string { | |||
|
|
|||
| func (c *Container) handleCheckpointingExternalNamespaces(rpcOpts *criurpc.CriuOpts, t configs.NamespaceType) error { | |||
| if !c.criuSupportsExtNS(t) { | |||
| return nil | |||
| return fmt.Errorf("criu version does not meet the requirements") | |||
There was a problem hiding this comment.
Maybe something more specific, like
return fmt.Errorf("criu lacks support for external %s namespace (old criu version?)", configs.NsName(t))There was a problem hiding this comment.
Yes, that's better. I will change it later.
It's hard to add a test as it would require installing some old criu version. |
kolyshkin
reviewed
Oct 9, 2024
Signed-off-by: yangzhao.hjh <yangzhao.hjh@alibaba-inc.com>
Good idea, there is the same problem in |
|
CI failures appear to be flakes (filed #4437). Failed CI jobs restarted. |
kolyshkin
requested changes
Oct 10, 2024
There was a problem hiding this comment.
@yangzhao02 please avoid adding merge commits (use git pull --rebase to rebase your working tree)
|
This pull request has been moved to #4440 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is used to solve When I use runc and criu 3.9, it crashed . When the criu version does not meet the requirements, execution will be terminated directly to prevent unpredictable behavior.