Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Terminate execution for criu that does not meet version requirements #4440

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

yangzhao02
Copy link
Contributor

@yangzhao02 yangzhao02 commented Oct 11, 2024

This is a carry of #4431.

Fixes: #4381.

When the criu version does not meet the requirements, execution will be terminated directly to prevent unpredictable behavior.

Signed-off-by: yangzhao.hjh <yangzhao.hjh@alibaba-inc.com>
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kolyshkin
Copy link
Contributor

@AkihiroSuda @rata PTAL

Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rata
Copy link
Member

rata commented Nov 1, 2024

Do we want to backport this?

@rata rata merged commit bb6aeed into opencontainers:main Nov 1, 2024
42 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I use runc and criu 3.9, it crashed
3 participants