Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SED-ML: upgrade to version L1V4 #2053

Closed
agarny opened this issue Apr 2, 2019 · 3 comments
Closed

SED-ML: upgrade to version L1V4 #2053

agarny opened this issue Apr 2, 2019 · 3 comments

Comments

@agarny
Copy link
Contributor

agarny commented Apr 2, 2019

With SED-ML L1V4 around the corner, it would be good to get OpenCOR to make use of it through the special L1V4 version of libSEDML.

@agarny agarny added the Task label Apr 2, 2019
@agarny agarny added this to the 0.7 milestone Apr 2, 2019
@agarny agarny self-assigned this Apr 2, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 2, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 2, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 2, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 2, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 2, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 3, 2019
….5 (L1V4) (opencor#2053).

Still using annotations for features that are in L1V4, but not in L1V3.
agarny added a commit to agarny/opencor that referenced this issue Apr 3, 2019
@agarny
Copy link
Contributor Author

agarny commented Apr 3, 2019

A bit of an issue here... Indeed, I would like OpenCOR to be able to read both L1V3 and L1V4 SED-ML files (since SED-ML support in OpenCOR started when L1V3 was already available), and (only) write L1V4 SED-ML files.

When it comes to reading L1V3 SED-ML files, the idea is to keep retrieving plot features, etc. from annotation (so that we can still read "old" OpenCOR-generated SED-ML files) while those features would be retrieved natively when reading L1V4 SED-ML files.

Now, the problem is that libSEDML used to create L1V2 documents by default (even when L1V3 was officially out), and I had never noticed it. So, many (all?) of our SED-ML files are actually considered to be L1V2 SED-ML files rather than L1V3 SED-ML files, which makes our testing for the level/version of a SED-ML file somewhat moot.

I guess I could still check for the level/version and if it is L1V4 (or newer) then OpenCOR would retrieve things natively otherwise through annotations. As for writing SED-ML documents, I would enforce the level/version to be L1V4 since the special L1V4 version of libSEDML currently creates L1V3 documents by default (see issue fbergmann/libSEDML#56).

@nickerso and @fbergmann, would you agree that this is the right way to go about this?

@nickerso
Copy link

nickerso commented Apr 3, 2019

I agree, sounds like the way to go.

agarny added a commit to agarny/opencor that referenced this issue Apr 4, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 4, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 23, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 23, 2019
agarny added a commit to agarny/opencor that referenced this issue Apr 23, 2019
Since libSBML was upgraded to version 5.18.0 (see issue opencor#2064).
agarny added a commit to agarny/opencor that referenced this issue Sep 3, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 3, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 4, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 4, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 4, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 4, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 5, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 5, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 5, 2019
agarny added a commit to agarny/opencor that referenced this issue Sep 30, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 1, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 1, 2019
…the title of a curve (opencor#2053).

Not sure we want to show a curve's id if it has no name. Indeed, otherwise we would have to do the same for a plot, and there are cases where we might simply not want a "title" for a plot while if a plot was to have no name then we would normally need to show its id, which is not what we want.
agarny added a commit to agarny/opencor that referenced this issue Oct 2, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 3, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 4, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 7, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 8, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 8, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 8, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 8, 2019
This was added to libSEDML in version 2.0.7.
agarny added a commit to agarny/opencor that referenced this issue Oct 9, 2019
agarny added a commit to agarny/opencor that referenced this issue Oct 10, 2019
@agarny
Copy link
Contributor Author

agarny commented Jul 8, 2021

This will be done as part of our move to libOpenCOR, so closing.

@agarny agarny closed this as completed Jul 8, 2021
@agarny agarny removed their assignment Jul 8, 2021
@agarny agarny removed the Task label Jul 8, 2021
@agarny agarny removed this from the 0.7 milestone Jul 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants