-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
SED-ML: upgrade to version L1V4 #2053
Comments
….5 (L1V4) (opencor#2053). Still using annotations for features that are in L1V4, but not in L1V3.
A bit of an issue here... Indeed, I would like OpenCOR to be able to read both L1V3 and L1V4 SED-ML files (since SED-ML support in OpenCOR started when L1V3 was already available), and (only) write L1V4 SED-ML files. When it comes to reading L1V3 SED-ML files, the idea is to keep retrieving plot features, etc. from annotation (so that we can still read "old" OpenCOR-generated SED-ML files) while those features would be retrieved natively when reading L1V4 SED-ML files. Now, the problem is that libSEDML used to create L1V2 documents by default (even when L1V3 was officially out), and I had never noticed it. So, many (all?) of our SED-ML files are actually considered to be L1V2 SED-ML files rather than L1V3 SED-ML files, which makes our testing for the level/version of a SED-ML file somewhat moot. I guess I could still check for the level/version and if it is L1V4 (or newer) then OpenCOR would retrieve things natively otherwise through annotations. As for writing SED-ML documents, I would enforce the level/version to be L1V4 since the special L1V4 version of libSEDML currently creates L1V3 documents by default (see issue fbergmann/libSEDML#56). @nickerso and @fbergmann, would you agree that this is the right way to go about this? |
I agree, sounds like the way to go. |
This reverts commit e572e86.
Since libSBML was upgraded to version 5.18.0 (see issue opencor#2064).
…our X and Y axes (opencor#2053).
…our X and Y axes (opencor#2053).
…our X and Y axes (opencor#2053).
…gend of a plot should be shown (opencor#2053).
…the title of a curve (opencor#2053).
…the title of a curve (opencor#2053). Not sure we want to show a curve's id if it has no name. Indeed, otherwise we would have to do the same for a plot, and there are cases where we might simply not want a "title" for a plot while if a plot was to have no name then we would normally need to show its id, which is not what we want.
… release of libSEDML 2.0.7 (opencor#2053).
This was added to libSEDML in version 2.0.7.
This will be done as part of our move to libOpenCOR, so closing. |
With SED-ML L1V4 around the corner, it would be good to get OpenCOR to make use of it through the special L1V4 version of libSEDML.
The text was updated successfully, but these errors were encountered: