Skip to content

chore!: remove excluded users from ListUsers response #64

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

ewanharris
Copy link
Member

Description

Removes excluded_users from the response of all SDKs as it was removed from OpenFGA with openfga/api#171.

This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g. user:*) as a means of being abundantly clear about what a user:* result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-add excluded_users at some point in the future but may or may not be a flattened list as previously implemented.

Please note:

  • This is technically a breaking but is acceptable provided that the ListUsers API is still experimental

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners June 14, 2024 10:19
@ewanharris ewanharris force-pushed the chore/excluded-users-removal branch 2 times, most recently from dd8cb23 to 6649cea Compare June 14, 2024 10:22
Co-authored-by: Will Vedder <willvedd@gmail.com>
@ewanharris ewanharris force-pushed the chore/excluded-users-removal branch from 6649cea to 8da4653 Compare June 14, 2024 10:24
@ewanharris ewanharris changed the title chore: remove excluded users from ListUsers response chore!: remove excluded users from ListUsers response Jun 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.96%. Comparing base (c77aa9d) to head (8da4653).

Files Patch % Lines
src/OpenFga.Sdk/Model/ListUsersResponse.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   30.74%   30.96%   +0.21%     
==========================================
  Files         120      119       -1     
  Lines        6095     6030      -65     
  Branches      792      784       -8     
==========================================
- Hits         1874     1867       -7     
+ Misses       4065     4007      -58     
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhamzeh rhamzeh added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 8ffebc0 Jun 14, 2024
11 checks passed
@rhamzeh rhamzeh deleted the chore/excluded-users-removal branch June 14, 2024 11:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants