Removing excluded users #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhamzeh
previously approved these changes
Jun 12, 2024
This was referenced Jun 13, 2024
rhamzeh
approved these changes
Jun 13, 2024
jon-whit
approved these changes
Jun 13, 2024
This was referenced Jun 13, 2024
This was referenced Jun 14, 2024
github-merge-queue bot
pushed a commit
to openfga/dotnet-sdk
that referenced
this pull request
Jun 14, 2024
## Description Removes `excluded_users` from the response of all SDKs as it was removed from OpenFGA with openfga/api#171. This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g. `user:*`) as a means of being abundantly clear about what a `user:*` result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-add excluded_users at some point in the future but may or may not be a flattened list as previously implemented. **Please note:** - This is technically a breaking but is acceptable provided that the ListUsers API is still experimental ## References - Related PR in openfga/sdk-generator: openfga/sdk-generator#377 - Related PR in openfga/api: openfga/api#171 ## Review Checklist - [x] I have clicked on ["allow edits by maintainers"](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork). - [ ] I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev) [Provide a link to any relevant PRs in the references section above] - [x] The correct base branch is being used, if not `main` - [ ] I have added tests to validate that the change in functionality is working as expected
This was referenced Jun 14, 2024
github-merge-queue bot
pushed a commit
to openfga/dotnet-sdk
that referenced
this pull request
Jun 17, 2024
## Description ``` - chore!: remove excluded users from ListUsers response BREAKING CHANGE: This version removes the `ExcludedUsers` field from the `ListUsersResponse` and `ClientListUsersResponse` classes, for more details see the [associated API change](openfga/api#171). ``` ## References ## Review Checklist - [x] I have clicked on ["allow edits by maintainers"](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork). - [ ] I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev) [Provide a link to any relevant PRs in the references section above] - [x] The correct base branch is being used, if not `main` - [ ] I have added tests to validate that the change in functionality is working as expected
4 tasks
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
excluded_usersfrom the ListUsers API response. This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g.user:*) as a means of being abundantly clear about what auser:*result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-addexcluded_usersat some point in the future but may or may not be a flattened list as previously implemented.Note: This is technically a breaking but is acceptable provided that the ListUsers API is still experimental.
Review Checklist
main