Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore!: remove excluded users from ListUsers response #112

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

ewanharris
Copy link
Member

Description

Removes excluded_users from the response of all SDKs as it was removed from OpenFGA with openfga/api#171.

This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g. user:*) as a means of being abundantly clear about what a user:* result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-add excluded_users at some point in the future but may or may not be a flattened list as previously implemented.

Please note:

  • This is technically a breaking but is acceptable provided that the ListUsers API is still experimental

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Co-authored-by: Will Vedder <willvedd@gmail.com>
@ewanharris ewanharris requested review from a team as code owners June 14, 2024 14:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (914cf92) to head (cc4e4b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files          18       18           
  Lines         968      968           
  Branches      220      220           
=======================================
  Hits          809      809           
  Misses         76       76           
  Partials       83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 2c78c5d Jun 17, 2024
19 checks passed
@ewanharris ewanharris deleted the chore/remove-excluded-users branch June 17, 2024 10:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants