Add tests and custom exceptions for index lookups in Topology #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1276, I found that
Topology.molecule_index
was only ever used in the machinery that checks which molecules had charges assigned to them. I added a couple of unit tests, custom exceptions, and updated some docstrings.I noticed there are a lot of bits in the
Topology
API that deal with particles, i.e.@j-wags would you accept a PR that removes or deprecates the concept of a "particle" since virtual sites are no longer a part of
Molecule
objects?