Deprecate particles #1303
Merged
Deprecate particles #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwthompson
changed the base branch from
master
to
topology-biopolymer-refactor
mattwthompson
force-pushed
the
remove-particles
branch
from
6610f1f to
07e4e11
Compare
Codecov Report
|
j-wags
approved these changes
May 20, 2022
| @@ -2092,18 +2046,6 @@ def bond(self, bond_topology_index): | |||
| return molecule.bond(bond_molecule_index) | |||
| this_molecule_start_index += molecule.n_bonds | |||
|
|
|||
| def add_particle(self, particle): | |||
…into remove-particles
This was referenced Jun 2, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1302 (comment)
There are a lot of method, variable, etc. names in the hierarchy implementation that name things
particle, and I think maybe these should beatominstead?