Fix #1542 #1543
Merged
Fix #1542 #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mattwthompson
commented
Feb 6, 2023
•
mattwthompson
commented
- Tag issue being addressed
- Add tests
- Update docstrings/documentation, if applicable
- Lint codebase
- Update changelog
mattwthompson
force-pushed
the
fix-1542
branch
from
abb5a18 to
592eb8c
Compare
j-wags
approved these changes
Feb 15, 2023
Comment on lines
+291
to
+292
| # TODO: What is the point of this argument? The default behavior includes a lot of logic. | ||
| # Unaware of cases in which the argument is used. |
There was a problem hiding this comment.
Let's keep this TODO in. I also don't know of anyone using a non-default argument here, but the behavior of all_subclasses is just so colossally automagic that I think there's decent value in letting users have access to a manual-entry mode.
|
Please update the releasenotes before you merge! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.