Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid circular import attempting to display "no cheminf toolkits installed" warning #1690

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Avoid circular import attempting to display "no cheminf toolkits installed" warning #1690

merged 2 commits into from
Aug 8, 2023

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Aug 8, 2023

@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #1690 (058c784) into main (7b94401) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@j-wags j-wags mentioned this pull request Aug 8, 2023
Merged
5 tasks
@j-wags j-wags changed the title Avoid circular import when throwing "no cheminf toolkits installed" error Avoid circular import when throwing "no cheminf toolkits installed" warning Aug 8, 2023
@j-wags j-wags changed the title Avoid circular import when throwing "no cheminf toolkits installed" warning Avoid circular import attempting to displey "no cheminf toolkits installed" warning Aug 8, 2023
mattwthompson
mattwthompson approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - awesome detective work @lilyminium and @j-wags! I totally missed that the unique thing about openff-fragmenter (-base) is the possibility that no wrapped toolkits are installed.

@j-wags j-wags changed the title Avoid circular import attempting to displey "no cheminf toolkits installed" warning Avoid circular import attempting to display "no cheminf toolkits installed" warning Aug 8, 2023
@j-wags j-wags merged commit f1f2fa2 into main Aug 8, 2023
@j-wags j-wags deleted the avoid-circular-import branch August 8, 2023 15:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mattwthompson mattwthompson mattwthompson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-wags @mattwthompson