Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid circular import attempting to display "no cheminf toolkits installed" warning #1690

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Avoid circular import attempting to display "no cheminf toolkits installed" warning #1690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
183a4c0
avoid circular import when throwing "no cheminf toolkits installed" e…
j-wags Aug 8, 2023
058c784
Update releasehistory.md
j-wags Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/releasehistory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ Releases follow the `major.minor.micro` scheme recommended by [PEP440](https://w
* `minor` increments add features but do not break API compatibility
* `micro` increments represent bugfix releases or improvements in documentation

## 0.14.3

### Bugfixes

- [PR #1690](https://github.com/openforcefield/openff-toolkit/pull/1690): Fixes a circular-import bug that occurs when attempting to print a "no cheminformatics toolkits available" warning.

## 0.14.2

## Behavior changes
### Behavior changes

- [PR #1679](https://github.com/openforcefield/openff-toolkit/pull/1679): Version 0.3 `<vdW>` sections of OFFXML files will automatically be up-converted (in memory) to version 0.4 according to the recomendations provided in [OFF-EP 0008](https://openforcefield.github.io/standards/enhancement-proposals/off-ep-0008/).

Expand Down
2 changes: 1 addition & 1 deletion openff/toolkit/utils/toolkits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
break

if not any_toolkits: # pragma: no cover
from openff.toolkit.utils import all_subclasses
from openff.toolkit.utils.utils import all_subclasses

msg = "WARNING: No basic cheminformatics toolkits are available.\n"
msg += "At least one basic toolkit is required to handle SMARTS matching and file I/O. \n"
Expand Down