Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lint with black and set up automated black check #677

Merged
merged 7 commits into from
Aug 17, 2020

Conversation

mattwthompson
Copy link
Member

Split out from #650. isort and black have some small disagreements that could be resolved here but I would rather deal with those later while resolving some flake8 complaints. The changes here are roughly the minimum to get this adopted as quickly as possible, and I tried to keep the commit history discrete if we wish to roll anything back.

@mattwthompson mattwthompson requested a review from j-wags August 10, 2020 16:38
Copy link
Contributor

@SimonBoothroyd SimonBoothroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed over most of the changes and it LGTM and suggested a few minor optional changes. Thanks @mattwthompson !

mattwthompson and others added 2 commits August 17, 2020 13:07
Co-authored-by: SimonBoothroyd <simon.boothroyd@colorado.edu>
Co-authored-by: SimonBoothroyd <simon.boothroyd@colorado.edu>
@mattwthompson
Copy link
Member Author

Thanks @SimonBoothroyd!

@mattwthompson mattwthompson merged commit cd8301b into master Aug 17, 2020
@mattwthompson mattwthompson mentioned this pull request Aug 17, 2020
7 tasks
@j-wags
Copy link
Member

j-wags commented Aug 18, 2020

Looks great. Thanks for making the call and merging this in -- I've been hesitating too much on this and it's good to just drop the hammer and deal with the consequences instead of leaving it hanging forever!

1 similar comment
@j-wags
Copy link
Member

j-wags commented Aug 18, 2020

Looks great. Thanks for making the call and merging this in -- I've been hesitating too much on this and it's good to just drop the hammer and deal with the consequences instead of leaving it hanging forever!

@mattwthompson mattwthompson deleted the lint-just-black branch May 25, 2021 19:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants