-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Lint with black and set up automated black check #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've skimmed over most of the changes and it LGTM and suggested a few minor optional changes. Thanks @mattwthompson !
Co-authored-by: SimonBoothroyd <simon.boothroyd@colorado.edu>
Co-authored-by: SimonBoothroyd <simon.boothroyd@colorado.edu>
Thanks @SimonBoothroyd! |
Looks great. Thanks for making the call and merging this in -- I've been hesitating too much on this and it's good to just drop the hammer and deal with the consequences instead of leaving it hanging forever! |
1 similar comment
Looks great. Thanks for making the call and merging this in -- I've been hesitating too much on this and it's good to just drop the hammer and deal with the consequences instead of leaving it hanging forever! |
Split out from #650.
isort
andblack
have some small disagreements that could be resolved here but I would rather deal with those later while resolving someflake8
complaints. The changes here are roughly the minimum to get this adopted as quickly as possible, and I tried to keep the commit history discrete if we wish to roll anything back.