Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add isort to linters #681

Merged
merged 7 commits into from
Aug 18, 2020
Merged

Add isort to linters #681

merged 7 commits into from
Aug 18, 2020

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Aug 17, 2020

Mirrors #677 but with isort, keeping with the spirit of minimizing the scope of each PR

  • Update linting action
  • update setup.cfg with isort settings - a notable difference between most linters and black, which typically takes no settings
  • Run isort
  • Tag issue being addressed
  • Add tests
  • Update docstrings/documentation, if applicable
  • Update changelog

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Before merging, could you also update the PR template to explain the linting steps to submitters? Maybe just add it as a checkbox, and link to the appropriate instructions in the docs?

@mattwthompson
Copy link
Member Author

Done - thanks @j-wags!

@mattwthompson mattwthompson merged commit 1e113fe into master Aug 18, 2020
@mattwthompson mattwthompson deleted the lint-just-isort branch May 25, 2021 19:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants