[harmonyhub] Suggestion for checking for current activity before starting a new activity

[ppieczul]

Expected Behavior

When I send PowerOff activity (by name) and hub is already in PowerOff state, it should do nothing.

Current Behavior

When I send PowerOff activity (by name) and hub is already in PowerOff state, it powers on one of my devices (last one). This is 100% reproducible in my setup. When hub is performing some activity is powers off correctly and does not start that device.

Possible Solution

Looking at the binding code, it is very likely that this is a bug in whistlingfish library or even more likely in harmony hub, as the original remote controller does not allow for such scenario to happen.

I think it would be nice to add checking for current state to handleCommand and update the hub only if requested activity is different to current one.

Although this is not a big issue and requires a workaround at upper level (for example in .rules file), from usability perspective, binding could be protected against such scenarios, which should not lead to some random activities.

Steps to Reproduce (for Bugs)

1. Add harmony hub, do not have to add any devices.
2. Create a rule that on some condition sends PowerOff activity to the hub.
3. In my case when hub was powered off, it started my projector.

Context

I have been trying to power off by AV system when motion sensor detected nobody in the room for 10 minutes. It resulted in my projector being powered on, when AV system was already down.

Your Environment

• OH snapshot 20170702112021
• Ubuntu Server 16.04