[harmonyhub] Fixes #2497 #2634
Closed
[harmonyhub] Fixes #2497 #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally fixed what static code analyzer complained about: no EOF in about.html and redundant import. Signed-off-by: Pawel Pieczul <pieczul@gmail.com> (github: ppieczul)
|
@ppieczul, thanks for your PR! By analyzing the history of the files in this pull request, we identified @digitaldan, @wborn and @kaikreuzer to be potential reviewers. |
|
@wborn can you review these changes? |
|
Maybe it would be better to create a PR to fix this issue in the underlying harmony-java-client library? This fix will be of use to non-openHAB library users and it would also close:
The |
|
Right and I have one more request to the whistlingfish library but it seems
it has not been taken care of for some months now. I don't know if this is
abandoned yet - do you have any contact with the author?
…On Thu, 31 Aug 2017 at 14:36, Wouter Born ***@***.***> wrote:
Maybe it would be better to create a PR to fix this issue in the
underlying harmony-java-client library?
This fix will be of use to non-openHAB library users and it would also
close:
- tuck182/harmony-java-client#13
<tuck182/harmony-java-client#13>
- tuck182/harmony-java-client#19
<tuck182/harmony-java-client#19> (by
@ppieczul <https://github.com/ppieczul>)
The net.whistlingfish.harmony.HarmonyClient is also keeping track of the
currentActivity
<https://github.com/tuck182/harmony-java-client/blob/master/src/main/java/net/whistlingfish/harmony/HarmonyClient.java#L88>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/openhab/openhab2-addons/pull/2634#issuecomment-326282092>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJx5fmjzo-eH2sxa51DBHflSL4EkWWcpks5sdqi9gaJpZM4PG9mG>
.
|
I've put in a few harmony-java-client PRs earlier this year and these were promptly merged. :-) |
|
Ok, we'll go this way, I got in touch with the author after some initial silence. Thanks. |
Flole998
pushed a commit
to Flole998/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Bump netty to 4.1.72.Final for log4j2 2.15.0 fix Signed-off-by: Matthew Skinner <matt@pcmus.com>
Flole998
pushed a commit
to Flole998/openhab-addons
that referenced
this pull request
Dec 30, 2021
…" (openhab#2646) This reverts commit 2f1ae2c.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2497.
This issue currently forces me to add checks against current activity in habpanel and rules.
I extended the fix to not sending activity set command to the hub library if the current activity is already that activity. This is exactly how Harmony remote controller works - you can't press a button to start an activity if this is the current activity.
Additionally fixed what static code analyzer complained about: no EOF in about.html and redundant import.
Signed-off-by: Pawel Pieczul pieczul@gmail.com (github: ppieczul)