Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Review visibility is not very visible on View Review page #2954

Closed
joemull opened this issue Jun 22, 2022 · 1 comment · Fixed by #3016
Closed

Review visibility is not very visible on View Review page #2954

joemull opened this issue Jun 22, 2022 · 1 comment · Fixed by #3016
Assignees
Labels
bug Something's not working

Comments

@joemull
Copy link
Member

joemull commented Jun 22, 2022

Is your feature request related to a problem? Please describe.
There are potentially 3 or more buttons / checkboxes on the View Review page (/review/article/<article_id>/review/<review_id>/view/) that control whether the author can see all or part of a peer review.

While the Janeway documentation and the help text on this page can together be analyzed to inform a guess as to whether a review or part of a review is visible, editors can still find it confusing and can second-guess the visibility of different parts of the review.

Describe the solution you'd like
Simplify the visibility-related components to have a single uniform appearance. This includes one type of label, callout, or toggle for whether something is currently visible, and one type of button or switch for changing the visibility.

ZYWtJ0MlOmsJ4phoTKn3LSyV_r_nErwi2Q

@joemull joemull added the bug Something's not working label Jun 22, 2022
@joemull
Copy link
Member Author

joemull commented Jun 22, 2022

Comments from an editor:

"Just to add that another aspect of confusion comes from the green 'allow author to see' which switches to red 'hide from author' when you click it. I clicked on them a number of times because I couldn't work out whether it was a command or a statement - as in when it was green did that mean they couldn't see it or did it mean I had to press it so they couldn't see it.

"Does this make sense? A more simple 'tick this box if you want them to see the review' would be more definitive and might remove the crisis of doubt that I suffered!"

@joemull joemull added this to v1.4.3 Jun 22, 2022
@joemull joemull moved this to Todo in v1.4.3 Jun 22, 2022
ajrbyers added a commit that referenced this issue Jul 20, 2022
@ajrbyers ajrbyers moved this from Todo to PR Submitted in v1.4.3 Jul 21, 2022
ajrbyers added a commit that referenced this issue Aug 19, 2022
ajrbyers added a commit that referenced this issue Sep 22, 2022
joemull added a commit that referenced this issue Sep 23, 2022
Repository owner moved this from PR Submitted to Done in v1.4.3 Sep 23, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something's not working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants