Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

2954 updates the review visibility settings to give them a unified style. #3016

Merged
merged 8 commits into from
Sep 23, 2022
Merged

2954 updates the review visibility settings to give them a unified style. #3016

merged 8 commits into from
Sep 23, 2022

Conversation

ajrbyers
Copy link
Member

Closes #2954

@joemull joemull self-requested a review July 21, 2022 12:34
joemull
joemull reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a big improvement and I'm looking forward to workshopping it with editors. I added an idea about submitting each form when a toggle changes.

@joemull
Copy link
Member

joemull commented Sep 5, 2022

One other thing on this branch, @ajrbyers, is to remember to update the documentation

@joemull joemull self-requested a review September 23, 2022 09:29
@joemull joemull merged commit ca943e1 into master Sep 23, 2022
@joemull joemull deleted the 2954-review_visibility branch September 23, 2022 15:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joemull joemull joemull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review visibility is not very visible on View Review page
2 participants
@ajrbyers @joemull