Skip to content

[release-v1.17] Use hacks directly #206

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

cardil
Copy link
Member

@cardil cardil commented Feb 14, 2025

/kind cleanup

Copy link

openshift-ci bot commented Feb 14, 2025

@cardil: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from alanfx and rhuss February 14, 2025 18:25
@cardil
Copy link
Member Author

cardil commented Feb 14, 2025

/cherrypick release-v1.16
/cherrypick release-v1.15
/cherrypick main

@openshift-cherrypick-robot

@cardil: once the present PR merges, I will cherry-pick it on top of main, release-v1.15, release-v1.16 in new PRs and assign them to you.

In response to this:

/cherrypick release-v1.16
/cherrypick release-v1.15
/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v1.17@70334cb). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.17     #206   +/-   ##
================================================
  Coverage                 ?   80.48%           
================================================
  Files                    ?       25           
  Lines                    ?     2029           
  Branches                 ?        0           
================================================
  Hits                     ?     1633           
  Misses                   ?      300           
  Partials                 ?       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Collaborator

skonto commented Feb 18, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aaed5e0 into openshift-knative:release-v1.17 Feb 18, 2025
25 checks passed
@openshift-cherrypick-robot

@cardil: new pull request created: #228

In response to this:

/cherrypick release-v1.16
/cherrypick release-v1.15
/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@cardil: new pull request created: #229

In response to this:

/cherrypick release-v1.16
/cherrypick release-v1.15
/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@cardil: new pull request created: #230

In response to this:

/cherrypick release-v1.16
/cherrypick release-v1.15
/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants