Run testselect directly

[creydr]

We're running into

Cloning into '/tmp/knative.D3EjJ6RQ/tmp.bAwqelmbkP'...
/tmp/knative.D3EjJ6RQ/tmp.bAwqelmbkP /go/src/github.com/openshift-knative/serverless-operator
go: inconsistent vendoring in /tmp/knative.D3EjJ6RQ/tmp.bAwqelmbkP:
	github.com/blang/semver/v4@v4.0.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
	github.com/coreos/go-semver@v0.3.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
        ...
	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor
12:32:11.730 ERROR:   🚨 Error (code: 1) occurred at /go/src/github.com/openshift-knative/serverless-operator/hack/lib/testselect.bash:10, with command: go install github.com/openshift-knative/hack/cmd/testselect

E.g. here

We don't need to clone hack repo anymore to install the tools, so run it directly

[creydr]

/cherry-pick release-1.35
/cherry-pick release-1.34

[openshift-cherrypick-robot]

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.34, release-1.35 in new PRs and assign them to you.

In response to this:

/cherry-pick release-1.35
/cherry-pick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cardil]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ab8cf34 and 2 for PR HEAD ba9ef39 in total

[cardil]

I opened PRs against o-k components to make sure to use hacks directly, without needing to install or fiddle with GOPATH:

• [release-next] Use go run for hacks directly eventing#1081
• [release-next] Use hacks directly eventing-kafka-broker#1510
• Use hacks directly eventing-hyperfoil-benchmark#90
• [release-next] Use hacks directly kn-plugin-func#1100
• [release-v1.17] Use hacks directly net-kourier#225
• [release-next] Use hacks directly serving#1183
• [release-next] Use hacks directly eventing-istio#442
• [release-v1.17] Use hacks directly net-istio#206

I doubt the above PRs are actually needed. The previous code should work, even without vendor on o-k/hack. In S-O it probably is some weird temporal GOPATH setup that caused the weird fail.

The search: https://github.com/search?q=org%3Aopenshift-knative+%22install+github.com%2Fopenshift-knative%2Fhack%22&type=code

[openshift-ci]

@creydr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/417-upstream-e2e	ba9ef39	link	false	/test 417-upstream-e2e
ci/prow/417-upstream-e2e-kafka	ba9ef39	link	false	/test 417-upstream-e2e-kafka
ci/prow/417-test-upgrade	ba9ef39	link	true	/test 417-test-upgrade
ci/prow/417-operator-e2e	ba9ef39	link	true	/test 417-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[creydr]

eventing-controller does not come up due to:

W0214 19:55:29.852917       1 reflector.go:547] knative.dev/pkg/controller/controller.go:726: failed to list *v1alpha1.IntegrationSource: integrationsources.sources.knative.dev is forbidden: User "system:serviceaccount:knative-eventing:eventing-controller" cannot list resource "integrationsources" in API group "sources.knative.dev" at the cluster scope
E0214 19:55:29.852949       1 reflector.go:150] knative.dev/pkg/controller/controller.go:726: Failed to watch *v1alpha1.IntegrationSource: failed to list *v1alpha1.IntegrationSource: integrationsources.sources.knative.dev is forbidden: User "system:serviceaccount:knative-eventing:eventing-controller" cannot list resource "integrationsources" in API group "sources.knative.dev" at the cluster scope
{"level":"fatal","ts":1739562944.983323,"logger":"fallback","caller":"injection/injection.go:65","msg":"Failed to start informers","error":"failed to wait for cache at index 14 to sync","stacktrace":"knative.dev/pkg/injection.EnableInjectionOrDie.func1\n\t/workspace/vendor/knative.dev/pkg/injection/injection.go:65\nknative.dev/pkg/injection/sharedmain.MainWithConfig\n\t/workspace/vendor/knative.dev/pkg/injection/sharedmain/main.go:309\nknative.dev/pkg/injection/sharedmain.MainWithContext\n\t/workspace/vendor/knative.dev/pkg/injection/sharedmain/main.go:209\nmain.main\n\t/workspace/cmd/controller/main.go:58\nruntime.main\n\t/usr/lib/golang/src/runtime/proc.go:271"}

#3387 should help on it

[creydr]

Closing this, in favor of #3387 (see #3387 (comment))