STOR-2263: Rebase to upstream v1.17.0 for OCP 4.19 #20
Conversation
doc: cut v1.16.0 release
Bumps build-image/debian-base from bookworm-v1.0.3 to bookworm-v1.0.4. --- updated-dependencies: - dependency-name: build-image/debian-base dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…docker/cmd/smbplugin/build-image/debian-base-bookworm-v1.0.4 chore(deps): bump build-image/debian-base from bookworm-v1.0.3 to bookworm-v1.0.4 in /cmd/smbplugin
os.RemoveAll() fails if at least one subdir doesn't have write permissions. See kubernetes-csi#834.
…ore-deletion fix: chmod volume dir before deletion
…olint-version chore: upgrade golint version
fix: mount with 0777 in volume creation and deletion
test: fix random ut failure
…-images4 chore: upgrade sidecar image versions
fix: remove parent dir in DeleteVolume
…me-permission fix: delete volume failure due to permission issue
test: use env var for enable driver install in e2e
If user sets `fsGroup: <gid>` in Pod's spec.securityContext, kubelet delegate fsGroup to CSI Driver, and NodeStageVolume() adds `gid=<gid>` to mount options. This might be not enough to make volume writable for the user: ``` $ kubectl exec fedora -- ls -ld /mnt/claim drwxr-xr-x. 2 root 1002 0 Sep 13 12:04 /mnt/claim $ kubectl exec fedora -- touch /mnt/claim/FILE touch: cannot touch '/mnt/claim/FILE': Permission denied ``` See kubernetes-csi#835
…vior fix: mount options for fsGroup delegation must ensure RWX for the group
227577e00 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee287 Always enable race detection while running tests 988496a1f Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c698 chore: bump to Go 1.22.5 69bd71e8a chore: add CSI_PROW_SIDECAR_E2E_PATH git-subtree-dir: release-tools git-subtree-split: 227577e00e93c3db4e732df1a71e37676fa33bfd
fix: build with go 1.22.5 to fix golang CVE
openshift-ci
bot
added
the
do-not-merge/hold
and remove .github
|
/retest |
|
/test unit |
rhrmo
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
rhrmo
force-pushed
the
rebase-1.17.0
branch
2 times, most recently
from
bcd2cb0 to
2263a2a
Compare
|
/retest |
|
@rhrmo: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
rhrmo
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm Units test are now passing with openshift/release#61509 (comment) merged. |
|
/assign @mpatlasov For approval. |
|
@rhrmo: This pull request references STOR-2263 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov, rhrmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
QE did pre merged tests on this rebase, all regression tests looks good only the new support changes(csi resize and inline volume) e2e failed which needs update from our csi driver operator side. I draft a PR -> openshift/csi-operator#358 to enable csi resize and inline volume support for smb csi driver. sh-5.1# ./bin/smbplugin --ver
Build Date: "2025-02-14T09:00:24Z"
Compiler: gc
Driver Name: smb.csi.k8s.io
Driver Version: v1.17.0
Git Commit: 2263a2add87612c96f1e283f747789da54159284
Go Version: go1.23.2 (Red Hat 1.23.2-1.el9) X:strictfipsruntime
Platform: linux/amd64
$ ginkgo run -v test/e2e --timeout=30min
------------------------------
Ran 15 of 16 Specs in 606.548 seconds
SUCCESS! -- 13 Passed | 2 Failed | 0 Pending | 1 Skipped |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@rhrmo: This pull request references STOR-2263 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit edc398a
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-smb-csi-driver |
Issue link:
https://issues.redhat.com/browse/STOR-2263
Diff to upstream v1.17.0:
kubernetes-csi/csi-driver-smb@v1.17.0...rhrmo:rebase-1.17.0
Important changes between 1.16.0 (OCP 4.18) and 1.17.0 (OCP 4.19):
Full changelogs:
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.17.0
@openshift/storage
@openshift/storage-qe